Skip to content

Commit 8886d49

Browse files
committed
Fix FunctionTypeUtils as well as LocalServerPort issue
Resolves #871
1 parent f998855 commit 8886d49

File tree

13 files changed

+19
-14
lines changed

13 files changed

+19
-14
lines changed

spring-cloud-function-context/src/main/java/org/springframework/cloud/function/context/catalog/FunctionTypeUtils.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -417,10 +417,15 @@ public static boolean isMessage(Type type) {
417417
type = getImmediateGenericType(type, 0);
418418
}
419419

420-
if (type instanceof ParameterizedType && !Message.class.isAssignableFrom(TypeResolver.resolveRawClass(type, null))) {
420+
Class<?> resolveRawClass = FunctionTypeUtils.getRawType(type);
421+
if (type instanceof ParameterizedType && !Message.class.isAssignableFrom(resolveRawClass)) {
421422
type = getImmediateGenericType(type, 0);
422423
}
423-
return Message.class.isAssignableFrom(TypeResolver.resolveRawClass(type, null));
424+
resolveRawClass = FunctionTypeUtils.getRawType(type);
425+
if (resolveRawClass == null) {
426+
return false;
427+
}
428+
return Message.class.isAssignableFrom(resolveRawClass);
424429
}
425430

426431
/**

spring-cloud-function-context/src/test/java/org/springframework/cloud/function/context/catalog/SimpleFunctionRegistryTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ public void before() {
102102
public void concurrencyRegistrationTest() throws Exception {
103103
Echo function = new Echo();
104104
FunctionRegistration<Echo> registration = new FunctionRegistration<>(
105-
function, "echo").type(FunctionType.of(Echo.class));
105+
function, "echo").type(Echo.class);
106106
SimpleFunctionRegistry catalog = new SimpleFunctionRegistry(this.conversionService, this.messageConverter,
107107
new JacksonMapper(new ObjectMapper()));
108108
ExecutorService executor = Executors.newCachedThreadPool();

spring-cloud-function-samples/function-sample-pojo/src/test/java/com/example/SampleApplicationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import org.springframework.boot.test.context.SpringBootTest;
2626
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
2727
import org.springframework.boot.test.web.client.TestRestTemplate;
28-
import org.springframework.boot.web.server.LocalServerPort;
28+
import org.springframework.boot.test.web.server.LocalServerPort;
2929
import org.springframework.http.HttpEntity;
3030
import org.springframework.http.HttpHeaders;
3131
import org.springframework.http.MediaType;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/flux/FluxRestApplicationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
import org.springframework.boot.test.context.SpringBootTest;
3737
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
3838
import org.springframework.boot.test.web.client.TestRestTemplate;
39-
import org.springframework.boot.web.server.LocalServerPort;
39+
import org.springframework.boot.test.web.server.LocalServerPort;
4040
import org.springframework.cloud.function.flux.FluxRestApplicationTests.TestConfiguration;
4141
import org.springframework.context.annotation.Configuration;
4242
import org.springframework.http.HttpStatus;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/mvc/MvcRestApplicationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
import org.springframework.boot.test.context.SpringBootTest;
3636
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
3737
import org.springframework.boot.test.web.client.TestRestTemplate;
38-
import org.springframework.boot.web.server.LocalServerPort;
38+
import org.springframework.boot.test.web.server.LocalServerPort;
3939
import org.springframework.cloud.function.mvc.MvcRestApplicationTests.TestConfiguration;
4040
import org.springframework.context.annotation.Configuration;
4141
import org.springframework.http.HttpStatus;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/scan/ComponentTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.springframework.boot.test.context.SpringBootTest;
2828
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
2929
import org.springframework.boot.test.web.client.TestRestTemplate;
30-
import org.springframework.boot.web.server.LocalServerPort;
30+
import org.springframework.boot.test.web.server.LocalServerPort;
3131
import org.springframework.context.annotation.ComponentScan;
3232
import org.springframework.http.HttpStatus;
3333
import org.springframework.http.MediaType;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/flux/HttpGetIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
3939
import org.springframework.boot.test.context.TestConfiguration;
4040
import org.springframework.boot.test.web.client.TestRestTemplate;
41-
import org.springframework.boot.web.server.LocalServerPort;
41+
import org.springframework.boot.test.web.server.LocalServerPort;
4242
import org.springframework.cloud.function.web.RestApplication;
4343
import org.springframework.cloud.function.web.flux.HttpGetIntegrationTests.ApplicationConfiguration;
4444
import org.springframework.context.annotation.Bean;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/flux/HttpPostIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import org.springframework.boot.test.context.SpringBootTest;
4141
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
4242
import org.springframework.boot.test.web.client.TestRestTemplate;
43-
import org.springframework.boot.web.server.LocalServerPort;
43+
import org.springframework.boot.test.web.server.LocalServerPort;
4444
import org.springframework.cloud.function.web.RestApplication;
4545
import org.springframework.cloud.function.web.flux.HttpPostIntegrationTests.ApplicationConfiguration;
4646
import org.springframework.context.annotation.Bean;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/flux/PrefixTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import org.springframework.boot.test.context.SpringBootTest;
2828
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
2929
import org.springframework.boot.test.web.client.TestRestTemplate;
30-
import org.springframework.boot.web.server.LocalServerPort;
30+
import org.springframework.boot.test.web.server.LocalServerPort;
3131
import org.springframework.cloud.function.web.RestApplication;
3232
import org.springframework.cloud.function.web.flux.PrefixTests.TestConfiguration;
3333
import org.springframework.context.annotation.Bean;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/flux/SingletonTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
import org.springframework.boot.test.context.SpringBootTest;
3333
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
3434
import org.springframework.boot.test.web.client.TestRestTemplate;
35-
import org.springframework.boot.web.server.LocalServerPort;
35+
import org.springframework.boot.test.web.server.LocalServerPort;
3636
import org.springframework.cloud.function.web.RestApplication;
3737
import org.springframework.cloud.function.web.flux.SingletonTests.TestConfiguration;
3838
import org.springframework.context.annotation.Bean;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/mvc/DefaultRouteTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
import org.springframework.boot.test.context.SpringBootTest;
2929
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
3030
import org.springframework.boot.test.web.client.TestRestTemplate;
31-
import org.springframework.boot.web.server.LocalServerPort;
31+
import org.springframework.boot.test.web.server.LocalServerPort;
3232
import org.springframework.cloud.function.web.RestApplication;
3333
import org.springframework.cloud.function.web.mvc.DefaultRouteTests.TestConfiguration;
3434
import org.springframework.context.annotation.Bean;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/mvc/HttpGetIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
4040
import org.springframework.boot.test.context.TestConfiguration;
4141
import org.springframework.boot.test.web.client.TestRestTemplate;
42-
import org.springframework.boot.web.server.LocalServerPort;
42+
import org.springframework.boot.test.web.server.LocalServerPort;
4343
import org.springframework.cloud.function.web.RestApplication;
4444
import org.springframework.cloud.function.web.mvc.HttpGetIntegrationTests.ApplicationConfiguration;
4545
import org.springframework.context.annotation.Bean;

spring-cloud-function-web/src/test/java/org/springframework/cloud/function/web/mvc/HttpPostIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
4141
import org.springframework.boot.test.context.TestConfiguration;
4242
import org.springframework.boot.test.web.client.TestRestTemplate;
43-
import org.springframework.boot.web.server.LocalServerPort;
43+
import org.springframework.boot.test.web.server.LocalServerPort;
4444
import org.springframework.cloud.function.web.RestApplication;
4545
import org.springframework.cloud.function.web.mvc.HttpPostIntegrationTests.ApplicationConfiguration;
4646
import org.springframework.context.annotation.Bean;

0 commit comments

Comments
 (0)