Improve performance of get_title()

Author: AA-Turner

sphinxext/opengraph/__init__.py

@@ -74,8 +74,7 @@ def get_tags(
         desc_len = DEFAULT_DESCRIPTION_LENGTH
 
     # Get the title and parse any html in it
-    title = get_title(context["title"], skip_html_tags=False)
-    title_excluding_html = get_title(context["title"], skip_html_tags=True)
+    title, title_excluding_html = get_title(context["title"])
 
     # Parse/walk doctree for metadata (tag/description)
     description = get_description(doctree, desc_len, [title, title_excluding_html])

sphinxext/opengraph/titleparser.py

@@ -26,12 +26,9 @@ def handle_data(self, data) -> None:
             self.text_outside_tags += data
 
 
-def get_title(title: str, skip_html_tags: bool = False):
+def get_title(title: str):
     htp = HTMLTextParser()
     htp.feed(title)
     htp.close()
 
-    if skip_html_tags:
-        return htp.text_outside_tags
-    else:
-        return htp.text
+    return htp.text, htp.text_outside_tags