Skip to content

Commit 25f9218

Browse files
phlaxAA-Turner
andcommitted
Remove Sphinx as a required dependency (#18)
Signed-off-by: Ryan Northey <[email protected]> Co-authored-by: Adam Turner <[email protected]>
1 parent 39ee387 commit 25f9218

File tree

4 files changed

+13
-4
lines changed

4 files changed

+13
-4
lines changed

Diff for: .github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
- name: Install dependencies
4545
run: |
4646
python -m pip install --upgrade pip
47-
python -m pip install .[test]
47+
python -m pip install .[test,standalone]
4848
4949
- name: Test with pytest
5050
run: python -m pytest -vv --durations 25

Diff for: CHANGES

+7
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
Release 2.0.5 (unreleased)
2+
==========================
3+
4+
* Remove Sphinx as a required dependency, as circular dependencies may cause
5+
failure with package managers that expect a directed acyclic graph (DAG)
6+
of dependencies.
7+
18
Release 2.0.4 (2023-08-14)
29
==========================
310

Diff for: pyproject.toml

+4-3
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@ classifiers = [
3939
"Topic :: Text Processing",
4040
"Topic :: Utilities",
4141
]
42-
dependencies = [
43-
"Sphinx>=5",
44-
]
42+
dependencies = []
4543
dynamic = ["version"]
4644

4745
[project.optional-dependencies]
@@ -54,6 +52,9 @@ lint = [
5452
"mypy",
5553
"docutils-stubs",
5654
]
55+
standalone = [
56+
"Sphinx>=5",
57+
]
5758

5859
[[project.authors]]
5960
name = "Georg Brandl"

Diff for: sphinxcontrib/htmlhelp/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,7 @@ def default_htmlhelp_basename(config: Config) -> str:
296296

297297

298298
def setup(app: Sphinx) -> dict[str, Any]:
299+
app.require_sphinx('5.0')
299300
app.setup_extension('sphinx.builders.html')
300301
app.add_builder(HTMLHelpBuilder)
301302
app.add_message_catalog(__name__, path.join(package_dir, 'locales'))

0 commit comments

Comments
 (0)