Don't display 'replaceable hardcoded link' when link has a slash (#10137)

Author: asottile

sphinx/ext/extlinks.py

@@ -72,7 +72,11 @@ def check_uri(self, refnode: nodes.reference) -> None:
                 uri_pattern = re.compile(re.escape(base_uri).replace('%s', '(?P<value>.+)'))
 
             match = uri_pattern.match(uri)
-            if match and match.groupdict().get('value'):
+            if (
+                match and
+                match.groupdict().get('value') and
+                '/' not in match.groupdict()['value']
+            ):
                 # build a replacement suggestion
                 msg = __('hardcoded link %r could be replaced by an extlink '
                          '(try using %r instead)')

tests/roots/test-ext-extlinks-hardcoded-urls-multiple-replacements/index.rst

@@ -17,6 +17,8 @@ https://github.com/octocat
 
 `replaceable link`_
 
+`non replaceable link <https://github.com/sphinx-doc/sphinx/pulls>`_
+
 .. hyperlinks
 
 .. _replaceable link: https://github.com/octocat

tests/test_ext_extlinks.py

@@ -28,6 +28,7 @@ def test_all_replacements_suggested_if_multiple_replacements_possible(app, warni
     app.build()
     warning_output = warning.getvalue()
     # there should be six warnings for replaceable URLs, three pairs per link
+    assert warning_output.count("WARNING: hardcoded link") == 6
     message = (
         "index.rst:%d: WARNING: hardcoded link 'https://github.com/octocat' "
         "could be replaced by an extlink (try using '%s' instead)"