SR-9930: Re-enable assertion in TestProcess.test_passthrough_environment()

spevans · spevans · commit b39cd038a097 · 2020-06-15T09:35:00.000+01:00
- This test is believed to have broken due to thread issues when reading from stdout/stderr of the child process. - The threading issue was fixed in swiftlang#2523
diff --git a/Tests/Foundation/Tests/TestProcess.swift b/Tests/Foundation/Tests/TestProcess.swift
@@ -217,9 +217,7 @@ class TestProcess : XCTestCase {
             let env = try parseEnv(output)
             XCTAssertGreaterThan(env.count, 0)
         } catch {
-            // FIXME: SR-9930 parseEnv fails if an environment variable contains
-            // a newline.
-            // XCTFail("Test failed: \(error)")
+            XCTFail("Test failed: \(error)")
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -217,9 +217,7 @@ class TestProcess : XCTestCase {`
`217`	`217`	`let env = try parseEnv(output)`
`218`	`218`	`XCTAssertGreaterThan(env.count, 0)`
`219`	`219`	`} catch {`
`220`		`- // FIXME: SR-9930 parseEnv fails if an environment variable contains`
`221`		`- // a newline.`
`222`		`- // XCTFail("Test failed: \(error)")`
	`220`	`+ XCTFail("Test failed: \(error)")`
`223`	`221`	`}`
`224`	`222`	`}`
`225`	`223`