scripts/ci: enable static checks on Arm

- Enable static analysis checks on Arm.
- Upgrade shellcheck-py to version 0.8.0.4 to provide Arm support.
- Improve the way mdl searches for Markdown files to avoid scanning
  unintended directories, such as the local "vendor" folder.

Signed-off-by: Xin Yang <[email protected]>
Change-Id: Iae772b06785273086665ff2d6f49cc5a113d1f07
Reviewed-on: https://review.spdk.io/gerrit/c/spdk/spdk-csi/+/17967
Tested-by: SPDK CI Jenkins <[email protected]>
Reviewed-by: Yibo Cai <[email protected]>
Reviewed-by: Jing Yan <[email protected]>
Reviewed-by: Antti Kervinen <[email protected]>

Author: xinydev

Makefile

@@ -80,7 +80,7 @@ shellcheck:
 mdl:
 	@echo === running mdl
 	@if hash mdl 2> /dev/null; then                                      \
-		find ./ -name "*.md" | xargs readlink -f  | xargs mdl --style scripts/ci/mdl_rules.rb; \
+		mdl --git-recurse --style scripts/ci/mdl_rules.rb .;             \
 	else                                                                 \
 	    echo Markdown linter not found, please install;                  \
 	    false                                          ;                 \

scripts/ci/common.sh

@@ -102,13 +102,13 @@ function install_packages_ubuntu() {
 					docker.io \
 					conntrack \
 					socat \
-					wget
+					wget \
+					python3-pip \
+					ruby \
+					git
 	systemctl start docker
-	# install static check tools only on x86 agent
-	if [ "$(arch)" == x86_64 ]; then
-		apt-get install -y python3-pip ruby
-		pip3 install yamllint==1.23.0 shellcheck-py==0.7.1.1
-	fi
+
+	pip3 install yamllint==1.23.0 shellcheck-py==0.8.0.4
 	gem install mdl -v 0.12.0
 }
 
@@ -121,7 +121,9 @@ function install_packages_fedora() {
 					bind-utils \
 					socat \
 					wget \
-					ruby
+					python3-pip \
+					ruby \
+					git
 	if ! hash docker &> /dev/null; then
 		dnf remove -y docker*
 		dnf install -y dnf-plugins-core
@@ -132,11 +134,7 @@ function install_packages_fedora() {
 	fi
 	systemctl start docker
 
-	# install static check tools only on x86 agent
-	if [ "$(arch)" == x86_64 ]; then
-		dnf install -y python3-pip ruby
-		pip3 install yamllint==1.23.0 shellcheck-py==0.7.1.1
-	fi
+	pip3 install yamllint==1.23.0 shellcheck-py==0.8.0.4
 	gem install mdl -v 0.12.0
 }
 
@@ -281,10 +279,7 @@ function build_spdkcsi() {
 	make clean
 	echo "======== build spdkcsi ========"
 	make -C "${ROOTDIR}" spdkcsi
-	if [ "$(arch)" == "x86_64" ]; then
-		echo "======== static check ========"
-		make -C "${ROOTDIR}" lint
-	fi
+	make -C "${ROOTDIR}" lint
 	echo "======== build container ========"
 	# XXX: should match image name:tag in Makefile
 	sudo docker rmi spdkcsi/spdkcsi:canary > /dev/null || :

scripts/golangci.yml

@@ -10,8 +10,8 @@
 
 # options for analysis running
 run:
-  # default concurrency is a available CPU number
-  concurrency: 2
+  # The default concurrency value is the number of available CPU.
+  # concurrency: 2
 
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 5m