Skip to content

Commit 0753a8b

Browse files
committed
dev: lock rubocop-shopify dependency for now
because a) we can't generate the ruby 2.6 ci image with the latest version of the gem (which dropped support for ruby <2.7). b) we kept getting CI breaks from eager updating, anyway At some point, I'd like to move all our development dependencies into the Gemfile, tighten the dependencies, and have dependabot send PRs for updates.
1 parent 829041f commit 0753a8b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

nokogiri.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ Gem::Specification.new do |spec|
349349
spec.add_development_dependency("rubocop-minitest", "~> 0.17")
350350
spec.add_development_dependency("rubocop-performance", "~> 1.12")
351351
spec.add_development_dependency("rubocop-rake", "~> 0.6")
352-
spec.add_development_dependency("rubocop-shopify", "~> 2.3")
352+
spec.add_development_dependency("rubocop-shopify", "= 2.5.0") # TODO: loosen this after dropping support for Ruby 2.6
353353
spec.add_development_dependency("ruby_memcheck", "~> 1.0")
354354
spec.add_development_dependency("simplecov", "~> 0.21")
355355

0 commit comments

Comments
 (0)