Do not rebegin serial port if user assigned it before lib begin. Add end() to beginSerial to allow ESP32 software serial.

nseidle · nseidle · commit 3be876640857 · 2021-12-28T14:49:23.000-07:00
diff --git a/src/SparkFun_u-blox_SARA-R5_Arduino_Library.cpp b/src/SparkFun_u-blox_SARA-R5_Arduino_Library.cpp
@@ -3044,7 +3044,8 @@ SARA_R5_error_t SARA_R5::init(unsigned long baud,
 
     if (_printDebug == true) _debugPort->println(F("Begin module init."));
 
-    beginSerial(baud); // Begin serial
+    if(hwAvailable() == -1)
+        beginSerial(baud); // If port is null, begin serial
 
     if (initType == SARA_R5_INIT_AUTOBAUD)
     {
@@ -3594,6 +3595,7 @@ void SARA_R5::beginSerial(unsigned long baud)
 #ifdef SARA_R5_SOFTWARE_SERIAL_ENABLED
     else if (_softSerial != NULL)
     {
+        _softSerial->end();
         _softSerial->begin(baud);
     }
 #endif

Original file line number	Diff line number	Diff line change
`@@ -3044,7 +3044,8 @@ SARA_R5_error_t SARA_R5::init(unsigned long baud,`
`3044`	`3044`
`3045`	`3045`	`if (_printDebug == true) _debugPort->println(F("Begin module init."));`
`3046`	`3046`
`3047`		`- beginSerial(baud); // Begin serial`
	`3047`	`+ if(hwAvailable() == -1)`
	`3048`	`+ beginSerial(baud); // If port is null, begin serial`
`3048`	`3049`
`3049`	`3050`	`if (initType == SARA_R5_INIT_AUTOBAUD)`
`3050`	`3051`	`{`
`@@ -3594,6 +3595,7 @@ void SARA_R5::beginSerial(unsigned long baud)`
`3594`	`3595`	`#ifdef SARA_R5_SOFTWARE_SERIAL_ENABLED`
`3595`	`3596`	`else if (_softSerial != NULL)`
`3596`	`3597`	`{`
	`3598`	`+ _softSerial->end();`
`3597`	`3599`	`_softSerial->begin(baud);`
`3598`	`3600`	`}`
`3599`	`3601`	`#endif`