Skip to content

Commit 810cdac

Browse files
committed
Increase MAX_PAYLOAD_SIZE and firmwareTypeLen for F10N (SPGL1L5)
1 parent 4219249 commit 810cdac

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/u-blox_GNSS.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8140,7 +8140,7 @@ bool DevUBLOXGNSS::getModuleInfo(uint16_t maxWait)
81408140
{
81418141
ptr += strlen("FWVER="); // Point to the firmware type (HPG etc.)
81428142
int i = 0;
8143-
while ((i < firmwareTypeLen) && (*ptr != '\0') && (*ptr != ' ')) // Extract the firmware type (3 chars)
8143+
while ((i < firmwareTypeLen) && (*ptr != '\0') && (*ptr != ' ')) // Extract the firmware type (3-7 chars)
81448144
moduleSWVersion->firmwareType[i++] = *ptr++;
81458145
moduleSWVersion->firmwareType[i] = '\0'; // NULL-terminate
81468146

src/u-blox_external_typedefs.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ struct sfe_ublox_ubx_logging_list_t
253253

254254
#ifndef MAX_PAYLOAD_SIZE
255255
// v2.0: keep this for backwards-compatibility, but this is largely superseded by setPacketCfgPayloadSize
256-
#define MAX_PAYLOAD_SIZE 246 // We need ~220 bytes for getProtocolVersion on most ublox modules
256+
#define MAX_PAYLOAD_SIZE 276 // We need >=250 bytes for getProtocolVersion on the NEO-F10N
257257
// #define MAX_PAYLOAD_SIZE 768 //Worst case: UBX_CFG_VALSET packet with 64 keyIDs each with 64 bit values
258258
#endif
259259

@@ -303,7 +303,7 @@ typedef struct
303303
} geofenceParams_t;
304304

305305
// Struct to hold the module software version
306-
#define firmwareTypeLen 3 // HPG, SPG, etc.
306+
#define firmwareTypeLen 7 // HPG, SPG, SPGL1L5, etc.
307307
#define moduleNameMaxLen 13 // Allow for: 4-chars minus 4-chars minus 3-chars
308308
typedef struct
309309
{

0 commit comments

Comments
 (0)