Skip to content

UBX_Integrity_Checker : incorrect error detection #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Eric-FR opened this issue Dec 21, 2021 · 7 comments · Fixed by #95
Closed

UBX_Integrity_Checker : incorrect error detection #94

Eric-FR opened this issue Dec 21, 2021 · 7 comments · Fixed by #95

Comments

@Eric-FR
Copy link

Eric-FR commented Dec 21, 2021

UBX_Integrity_Checker is reporting a lot of errors on my ubx log files recorded since 21/12/17.

Sparkfun RTK Express with RTK_Surveyor_Firmware_v110-RCDec-13.zip. Logging on the µSD card.

Static recording with or without RTK correction.

UBX_Integrity_Checker is complaining about:
Panic!! Excessive NMEA message length!

image

image

Sample log (without RTK correction):
SFE_Express_211221_122914.zip

No problem with ubx_convert, u-center or rtklib (RTKPlot and RTKConv).

RTK Express settings:
SFE_Express_Settings.txt

@Eric-FR
Copy link
Author

Eric-FR commented Dec 21, 2021

With ubx_convert:
image

@PaulZC
Copy link
Collaborator

PaulZC commented Dec 22, 2021

Hi @Eric-FR ,

Thank you for reporting this.

The code was using a maximum NMEA length ( max_nmea_len ) of 100 characters:

max_nmea_len = 100 # Maximum length for an NMEA message: use this to detect if we have lost sync while receiving an NMEA message

But, from your data, I can see that the PUBX (u-blox proprietary NMEA messages) can exceed that.

I have updated the tool: I have increased the maximum length to 128; and also record the longest NMEA message length.

image

Enjoy!
Paul

@Eric-FR
Copy link
Author

Eric-FR commented Dec 28, 2021

Do you have any reason to believe that NMEA sentences length will not be higher than 128?
I just found one with 116 characters:

$PUBX,00,122623.00,4511.08102,N,00544.93346,E,264.521,D3,0.014,0.012,0.013,0.00,-0.006,1.0,0.58,0.86,0.60,25,0,0*55

@PaulZC
Copy link
Collaborator

PaulZC commented Dec 28, 2021

128 is just an "educated guess"!

If you see PUBX messages longer than this, please let me know. Thanks!

@Eric-FR
Copy link
Author

Eric-FR commented Dec 30, 2021

Although I can't find the official source of NMEA standard (that may not be freely available), it is commonly stated like in wikipedia that:

Messages have a maximum length of 82 characters, including the $ or ! starting character and the ending

So, PUBX don't comply with NMEA standard, isn't it?

Should we have a soft warning for sentences exceeding 82 characters and stronger action over a higher limit like 128 characters?

@Eric-FR
Copy link
Author

Eric-FR commented Dec 30, 2021

I just found classical sentences exceeding the official limit:

$GNGGA,185118.00,4533.5955918,N,00555.8326327,E,4,12,0.68,316.817,M,47.337,M,1.0,0000*6E

@nseidle
Copy link
Member

nseidle commented Dec 30, 2021

Is that with high precision turned on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants