Skip to content

Ability to set Position Accuracy #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyclops1982 opened this issue May 29, 2024 · 3 comments
Closed

Ability to set Position Accuracy #223

cyclops1982 opened this issue May 29, 2024 · 3 comments

Comments

@cyclops1982
Copy link
Contributor

Can we set Position accuracy?

Hi, i'm wondering if it would be possible to set the Position Accuracy mask via UBX-CFG-NAV5 message in this library?

I can't find a method for this, and i'm wondering why it's not there.
Would a PR with that added be accepted?

Your workbench

  • RAK12500 (WisBlock GNSS GPS Location Module u-blox ZOE-M8Q)
@PaulZC
Copy link
Collaborator

PaulZC commented May 30, 2024

Hi Ruben (@cyclops1982 ),

If you want full control over NAV5, you could achieve that with a custom command - see Example20.

If you just want to change pAcc via posMask, then yes, sure, we would accept a PR. I'd suggest starting with setDynamicModel and adapt it for setPositionMask. Add your new methods to .h, .cpp and keywords.txt.

Looking at the code for setDynamicModel, I'm wondering if I should be using read-modify-write on the two mask bytes? I think this line should be deleted, and this line should actually be:

payloadCfg[0] |= 0x01; // Set the dyn bit - leave others unmodified

Please include those changes in your PR.

For posMask, you want payloadCfg[0] |= 0x10; and load your uint16_t pAcc into payloadCfg[18] and payloadCfg[19] - little endian.

Best wishes,
Paul

@cyclops1982
Copy link
Contributor Author

cyclops1982 commented May 30, 2024

Thanks @PaulZC - PR #224 created. Please have a look, very welcome to receive feedback!

It does seem to need a change to make sure 18 and 19 are filled instead of jsut 18.

@PaulZC
Copy link
Collaborator

PaulZC commented May 30, 2024

Resolved by #224

@PaulZC PaulZC closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants