Skip to content

Commit c39be3e

Browse files
committed
Clean up getRXMSFRBX and getNAVEOE comments
1 parent 9ac6d20 commit c39be3e

File tree

1 file changed

+4
-30
lines changed

1 file changed

+4
-30
lines changed

Diff for: src/SparkFun_u-blox_GNSS_Arduino_Library.cpp

+4-30
Original file line numberDiff line numberDiff line change
@@ -10377,10 +10377,7 @@ bool SFE_UBLOX_GNSS::getNAVEOE(uint16_t maxWait)
1037710377
}
1037810378
else
1037910379
{
10380-
// if (_printDebug == true)
10381-
// {
10382-
// _debugSerial->println(F("getEOE: Polling"));
10383-
// }
10380+
// Note to self: NAV-EOE is "Periodic" (only). Not sure if it can be polled?
1038410381

1038510382
// The GPS is not automatically reporting navigation position so we have to poll explicitly
1038610383
packetCfg.cls = UBX_CLASS_NAV;
@@ -10396,18 +10393,9 @@ bool SFE_UBLOX_GNSS::getNAVEOE(uint16_t maxWait)
1039610393

1039710394
if (retVal == SFE_UBLOX_STATUS_DATA_OVERWRITTEN)
1039810395
{
10399-
// if (_printDebug == true)
10400-
// {
10401-
// _debugSerial->println(F("getEOE: data in packetCfg was OVERWRITTEN by another message (but that's OK)"));
10402-
// }
1040310396
return (true);
1040410397
}
1040510398

10406-
// if (_printDebug == true)
10407-
// {
10408-
// _debugSerial->print(F("getEOE retVal: "));
10409-
// _debugSerial->println(statusString(retVal));
10410-
// }
1041110399
return (false);
1041210400
}
1041310401
}
@@ -13504,23 +13492,9 @@ bool SFE_UBLOX_GNSS::getRXMSFRBX(uint16_t maxWait)
1350413492
}
1350513493
else
1350613494
{
13507-
// The GPS is not automatically reporting navigation position so we have to poll explicitly
13508-
packetCfg.cls = UBX_CLASS_RXM;
13509-
packetCfg.id = UBX_RXM_SFRBX;
13510-
packetCfg.len = 0;
13511-
packetCfg.startingSpot = 0;
13512-
13513-
// The data is parsed as part of processing the response
13514-
sfe_ublox_status_e retVal = sendCommand(&packetCfg, maxWait);
13515-
13516-
if (retVal == SFE_UBLOX_STATUS_DATA_RECEIVED)
13517-
return (true);
13518-
13519-
if (retVal == SFE_UBLOX_STATUS_DATA_OVERWRITTEN)
13520-
{
13521-
return (true);
13522-
}
13523-
13495+
// SFRBX is output-only. It cannot be polled...
13496+
// Strictly, getRXMSFRBX should be deprecated. But, to keep the library backward compatible, return(false) here.
13497+
// See issue #167 for details
1352413498
return (false);
1352513499
}
1352613500
}

0 commit comments

Comments
 (0)