Skip to content

Commit a8e753b

Browse files
committed
Final tweaks for v2.0.18
1 parent 5479950 commit a8e753b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

Diff for: src/SparkFun_u-blox_GNSS_Arduino_Library.cpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,6 @@ bool SFE_UBLOX_GNSS::checkUbloxI2C(ubxPacket *incomingUBX, uint8_t requestedClas
845845

846846
while (bytesAvailable)
847847
{
848-
// PaulZC : November 15th 2021
849848
// From the u-blox integration manual:
850849
// "There are two forms of DDC read transfer. The "random access" form includes a peripheral register
851850
// address and thus allows any register to be read. The second "current address" form omits the
@@ -869,15 +868,15 @@ bool SFE_UBLOX_GNSS::checkUbloxI2C(ubxPacket *incomingUBX, uint8_t requestedClas
869868

870869
//Here it would be desireable to use a restart where possible / supported, but only if there will be multiple reads.
871870
//However, if an individual requestFrom fails, we could end up leaving the bus hanging.
872-
//On balance, it is probably safest to not use restarts.
871+
//On balance, it is probably safest to not use restarts here.
873872
uint8_t bytesReturned = _i2cPort->requestFrom((uint8_t)_gpsI2Caddress, (uint8_t)bytesToRead);
874873
if ((uint16_t)bytesReturned == bytesToRead)
875874
{
876875
for (uint16_t x = 0; x < bytesToRead; x++)
877876
{
878877
uint8_t incoming = _i2cPort->read(); //Grab the actual character
879878

880-
//Check to see if the first read is 0x7F. If it is, the module is not ready to respond. Stop, wait, and try again
879+
//Check to see if the first read is 0x7F. If it is, the module is not ready to respond. Stop, wait, and try again.
881880
//Note: the integration manual says:
882881
//"If there is no data awaiting transmission from the receiver, then this register will deliver the value 0xFF,
883882
// which cannot be the first byte of a valid message."
@@ -3185,7 +3184,7 @@ void SFE_UBLOX_GNSS::printPacket(ubxPacket *packet, bool alwaysPrintPayload)
31853184
// Only print the payload is ignoreThisPayload is false otherwise
31863185
// we could be printing gibberish from beyond the end of packetBuf
31873186
// (These two lines get rid of a pesky compiler warning)
3188-
bool printPayload = (ignoreThisPayload == false);
3187+
bool printPayload = (ignoreThisPayload == false);
31893188
printPayload |= (alwaysPrintPayload == true);
31903189

31913190
#ifndef SFE_UBLOX_REDUCED_PROG_MEM

0 commit comments

Comments
 (0)