Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

Commit 1075c2e

Browse files
committed
Removing two incorrect inversions. These were preventing OVERWRITTEN being detected.
1 parent 9bc3a2d commit 1075c2e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: src/SparkFun_Ublox_Arduino_Library.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -1412,7 +1412,7 @@ sfe_ublox_status_e SFE_UBLOX_GPS::waitForACKResponse(ubxPacket *outgoingUBX, uin
14121412
// If (e.g.) a PVT packet _has been_ received: outgoingUBX->valid will be VALID (or just possibly NOT_VALID)
14131413
// So we cannot use outgoingUBX->valid as part of this check.
14141414
// Note: the addition of packetBuf should make this check redundant!
1415-
else if ((outgoingUBX->classAndIDmatch == SFE_UBLOX_PACKET_VALIDITY_VALID) && (packetAck.classAndIDmatch == SFE_UBLOX_PACKET_VALIDITY_VALID) && !((outgoingUBX->cls != requestedClass) || (outgoingUBX->id != requestedID)))
1415+
else if ((outgoingUBX->classAndIDmatch == SFE_UBLOX_PACKET_VALIDITY_VALID) && (packetAck.classAndIDmatch == SFE_UBLOX_PACKET_VALIDITY_VALID) && ((outgoingUBX->cls != requestedClass) || (outgoingUBX->id != requestedID)))
14161416
{
14171417
if (_printDebug == true)
14181418
{
@@ -1564,7 +1564,7 @@ sfe_ublox_status_e SFE_UBLOX_GPS::waitForNoACKResponse(ubxPacket *outgoingUBX, u
15641564
// If (e.g.) a PVT packet _has been_ received: outgoingUBX->valid will be VALID (or just possibly NOT_VALID)
15651565
// So we cannot use outgoingUBX->valid as part of this check.
15661566
// Note: the addition of packetBuf should make this check redundant!
1567-
else if ((outgoingUBX->classAndIDmatch == SFE_UBLOX_PACKET_VALIDITY_VALID) && !((outgoingUBX->cls != requestedClass) || (outgoingUBX->id != requestedID)))
1567+
else if ((outgoingUBX->classAndIDmatch == SFE_UBLOX_PACKET_VALIDITY_VALID) && ((outgoingUBX->cls != requestedClass) || (outgoingUBX->id != requestedID)))
15681568
{
15691569
if (_printDebug == true)
15701570
{

0 commit comments

Comments
 (0)