Skip to content

keypad initialization errors #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tbatmanb opened this issue May 5, 2016 · 1 comment
Open

keypad initialization errors #1

tbatmanb opened this issue May 5, 2016 · 1 comment

Comments

@tbatmanb
Copy link

tbatmanb commented May 5, 2016

Hi,
the keypad init routine contains two errors which are leading to wrong operation of other IO Pins.

please modify lines 349, 350, 537, 538 as shown below.
old 349 for (int i=8; i<(columns * 2); i++) // this couldn't work as desired
old 350 tempWord |= (1<<i);

new 349 for (int i=0; i<columns; i++) // this way, it works as desired
new 350 tempWord |= (1<<(i+8)); // <--- i+8

old 537 for (int i = 0; i < (8 + numCols); i++) // this couldn't work as desired
old 538 debouncePin(i);

new 537 for (int i = 0; i < (numCols); i++) // this way, it works as desired
new 538 debouncePin(i + 8); // <--- i+8

;-) one beer less ware
best regards
thomas

@gb-123-git
Copy link
Contributor

I think this has already been solved, as refered in #7 so it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants