detekt issues

Former-commit-id: 1c48447

Author: BFergerson

config/detekt/detekt.yml

@@ -6,7 +6,7 @@ build:
 
 comments:
   UndocumentedPublicClass:
-    active: true
+    active: false #todo: turned off as it's scanning generated code
 
 formatting:
   Indentation:

marker/src/main/kotlin/com/sourceplusplus/marker/source/SourceFileMarker.kt

@@ -48,7 +48,7 @@ open class SourceFileMarker(val psiFile: PsiFile) : SourceMarkProvider {
                     is KtFile -> true
                     else -> false
                 }
-            } catch (ex: NoClassDefFoundError) {
+            } catch (ignore: NoClassDefFoundError) {
                 false
             }
         }

marker/src/main/kotlin/com/sourceplusplus/marker/source/SourceMarkerUtils.kt

@@ -38,7 +38,7 @@ object SourceMarkerUtils {
      * @since 0.1.0
      */
     @JvmStatic
-    fun getElementAtLine(file: PsiFile, line: Int): PsiElement? {
+    fun getElementAtLine(file: PsiFile, line: Int): PsiElement {
         val document: Document = PsiDocumentManager.getInstance(file.project).getDocument(file)!!
         val offset = document.getLineStartOffset(line - 1)
         var element: PsiElement = file.viewProvider.findElementAt(offset)!!
@@ -503,7 +503,7 @@ object SourceMarkerUtils {
                 } else {
                     qualifiedType.qualifiedName
                 }
-                for (i in 0 until arrayDimensions) {
+                repeat(arrayDimensions) {
                     methodParams += "[]"
                 }
             } else {

marker/src/main/kotlin/com/sourceplusplus/marker/source/mark/api/ClassSourceMark.kt

@@ -39,7 +39,7 @@ abstract class ClassSourceMark(
     override val valid: Boolean; get() {
         return try {
             psiClass.isPsiValid && artifactQualifiedName == psiClass.qualifiedName!!
-        } catch (ex: PsiInvalidElementAccessException) {
+        } catch (ignore: PsiInvalidElementAccessException) {
             false
         }
     }

marker/src/main/kotlin/com/sourceplusplus/marker/source/mark/api/ExpressionSourceMark.kt

@@ -39,7 +39,7 @@ abstract class ExpressionSourceMark(
     override val valid: Boolean; get() {
         return try {
             psiExpression.isPsiValid && artifactQualifiedName == SourceMarkerUtils.getFullyQualifiedName(psiExpression)
-        } catch (ex: PsiInvalidElementAccessException) {
+        } catch (ignore: PsiInvalidElementAccessException) {
             false
         }
     }

marker/src/main/kotlin/com/sourceplusplus/marker/source/mark/api/MethodSourceMark.kt

@@ -39,7 +39,7 @@ abstract class MethodSourceMark(
     override val valid: Boolean; get() {
         return try {
             psiMethod.isPsiValid && artifactQualifiedName == SourceMarkerUtils.getFullyQualifiedName(psiMethod)
-        } catch (ex: PsiInvalidElementAccessException) {
+        } catch (ignore: PsiInvalidElementAccessException) {
             false
         }
     }

marker/src/main/kotlin/com/sourceplusplus/marker/source/mark/api/component/jcef/SourceMarkJcefComponent.kt

@@ -23,7 +23,6 @@ class SourceMarkJcefComponent(
 ) : SourceMarkComponent {
 
     companion object {
-        private val log = LoggerFactory.getLogger(SourceMarkJcefComponent::class.java)
         private val client: JBCefClient by lazy { JBCefApp.getInstance().createClient() }
 
         init {

marker/src/main/kotlin/com/sourceplusplus/marker/source/mark/gutter/GutterMark.kt

@@ -12,10 +12,6 @@ import org.slf4j.LoggerFactory
  */
 interface GutterMark : SourceMark {
 
-    companion object {
-        private val log = LoggerFactory.getLogger(GutterMark::class.java)
-    }
-
     override val type: SourceMark.Type
         get() = SourceMark.Type.GUTTER
     override val configuration: GutterMarkConfiguration

marker/src/main/kotlin/com/sourceplusplus/marker/source/mark/inlay/InlayMark.kt

@@ -12,10 +12,6 @@ import org.slf4j.LoggerFactory
  */
 interface InlayMark : SourceMark {
 
-    companion object {
-        private val log = LoggerFactory.getLogger(InlayMark::class.java)
-    }
-
     override val type: SourceMark.Type
         get() = SourceMark.Type.INLAY
     override val configuration: InlayMarkConfiguration