Skip to content

Passthrough for non-diff output #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
craigfurman opened this issue Mar 12, 2021 · 3 comments · Fixed by #60
Closed

Passthrough for non-diff output #59

craigfurman opened this issue Mar 12, 2021 · 3 comments · Fixed by #60

Comments

@craigfurman
Copy link
Contributor

I've recently started using this library, to redact diffs that pertain to secret files from logs. It would be great if (Multi)FileDiffReader could yield content that is not part of a valid diff, so that the caller has the choice of whether or not to print it.

For example, the program colordiff will successfully print non-diff output, allowing it to be used to process input that is mixed diff and non-diff content.

What do you think of this feature, and would you be interested in a PR that implements it?

@keegancsmith
Copy link
Member

cc @mrnugget @eseliger

@mrnugget
Copy link
Contributor

That sounds reasonable - if the implemenation doesn't become convoluted, I think we'd accept a PR, yes :)

@craigfurman
Copy link
Contributor Author

OK, I've had a go at it here: #60

let me know what you think 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants