Skip to content

Commit 0a19be4

Browse files
1295: Set a constant faker seed for deterministic tests. r=carols10cents A crucial fix for visual testing. Connects to rust-lang#1293.
2 parents 9960545 + d6c3bca commit 0a19be4

File tree

9 files changed

+19
-8
lines changed

9 files changed

+19
-8
lines changed

tests/acceptance/categories-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupApplicationTest } from 'ember-qunit';
33
import { visit } from '@ember/test-helpers';
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import axeConfig from '../axe-config';
6-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
6+
import setupMirage from '../helpers/setup-mirage';
77
import { percySnapshot } from 'ember-percy';
88

99
module('Acceptance | categories', function(hooks) {

tests/acceptance/crate-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { setupApplicationTest } from 'ember-qunit';
44
import { click, fillIn, currentURL, currentRouteName, visit } from '@ember/test-helpers';
55
import a11yAudit from 'ember-a11y-testing/test-support/audit';
66
import axeConfig from '../axe-config';
7-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
7+
import setupMirage from '../helpers/setup-mirage';
88
import { percySnapshot } from 'ember-percy';
99

1010
module('Acceptance | crate page', function(hooks) {

tests/acceptance/crates-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupApplicationTest } from 'ember-qunit';
33
import { click, currentURL, visit } from '@ember/test-helpers';
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import axeConfig from '../axe-config';
6-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
6+
import setupMirage from '../helpers/setup-mirage';
77
import { percySnapshot } from 'ember-percy';
88

99
module('Acceptance | crates page', function(hooks) {

tests/acceptance/front-page-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupApplicationTest } from 'ember-qunit';
33
import { currentURL, visit } from '@ember/test-helpers';
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import axeConfig from '../axe-config';
6-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
6+
import setupMirage from '../helpers/setup-mirage';
77
import { percySnapshot } from 'ember-percy';
88

99
module('Acceptance | front page', function(hooks) {

tests/acceptance/keyword-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupApplicationTest } from 'ember-qunit';
33
import { visit } from '@ember/test-helpers';
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import axeConfig from '../axe-config';
6-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
6+
import setupMirage from '../helpers/setup-mirage';
77
import { percySnapshot } from 'ember-percy';
88

99
module('Acceptance | keywords', function(hooks) {

tests/acceptance/search-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { fillIn, currentURL, triggerEvent, visit, blur } from '@ember/test-helpe
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import { triggerKeyDown, triggerKeyPress } from 'ember-keyboard';
66
import axeConfig from '../axe-config';
7-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
7+
import setupMirage from '../helpers/setup-mirage';
88
import { percySnapshot } from 'ember-percy';
99

1010
module('Acceptance | search', function(hooks) {

tests/acceptance/team-page-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupApplicationTest } from 'ember-qunit';
33
import { visit } from '@ember/test-helpers';
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import axeConfig from '../axe-config';
6-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
6+
import setupMirage from '../helpers/setup-mirage';
77
import { percySnapshot } from 'ember-percy';
88

99
module('Acceptance | team page', function(hooks) {

tests/acceptance/user-page-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { setupApplicationTest } from 'ember-qunit';
33
import { visit } from '@ember/test-helpers';
44
import a11yAudit from 'ember-a11y-testing/test-support/audit';
55
import axeConfig from '../axe-config';
6-
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
6+
import setupMirage from '../helpers/setup-mirage';
77
import { percySnapshot } from 'ember-percy';
88

99
module('Acceptance | user page', function(hooks) {

tests/helpers/setup-mirage.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
2+
import { faker } from 'ember-cli-mirage';
3+
4+
export default function(hooks) {
5+
setupMirage(hooks);
6+
7+
// To have deterministic visual tests, the seed has to be constant
8+
hooks.beforeEach(function() {
9+
faker.seed(12345);
10+
});
11+
}

0 commit comments

Comments
 (0)