functests: remove dead code and uses groupvars

This change removes some dead code and change the functional tests config to only
uses the groupvars. Removing the sleep in serverspec actually reveals
a concurency issue where the initial sfconfig run create a
post-job still running when the health-check gets triggered.

Change-Id: I51fc513c51b1e064009f020c47ffb99fc85992aa

Author: TristanCacqueray

Diff for: playbooks/config_submit_change.yaml

@@ -13,11 +13,6 @@
 
 - hosts: jenkins
   tasks:
-    - name: Check for config-check failure
-      when: hostvars[groups["install-server"][0]]["submit_status"].rc != 0
-      command: "cat /var/lib/jenkins/jobs/config-check/builds/lastFailedBuild/log"
-      failed_when: true
-
     - name: Check for config-update post job
       wait_for:
         path: /var/lib/jenkins/jobs/config-update/builds/lastStableBuild/build.xml