Skip to content

Commit f5ec45a

Browse files
author
svorenova
committed
Adding JIRA tickets cont.
1 parent 1fa8e2f commit f5ec45a

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

unit/java_bytecode/java_bytecode_parse_generics/parse_bounded_generic_inner_classes.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ SCENARIO(
6464
require_type::require_java_generic_class(
6565
class_symbol.type, {boundedinner_name + "::NUM"});
6666

67-
//TODO extend when bounds are parsed correctly - TG-1286
67+
// TODO extend when bounds are parsed correctly - TG-1286
6868

6969
THEN("The fields are of correct types")
7070
{
@@ -103,7 +103,7 @@ SCENARIO(
103103
require_type::require_java_generic_class(
104104
class_symbol.type, {doubleboundedinner_name + "::T"});
105105

106-
//TODO extend when bounds are parsed correctly - TG-1286
106+
// TODO extend when bounds are parsed correctly - TG-1286
107107

108108
THEN("The fields are of correct types")
109109
{
@@ -133,7 +133,7 @@ SCENARIO(
133133
class_symbol.type,
134134
{twoelementinner_name + "::K", twoelementinner_name + "::V"});
135135

136-
//TODO extend when bounds are parsed correctly - TG-1286
136+
// TODO extend when bounds are parsed correctly - TG-1286
137137

138138
THEN("The fields are of correct types")
139139
{

unit/java_bytecode/java_bytecode_parse_generics/parse_generic_functions.cpp

-2
Original file line numberDiff line numberDiff line change
@@ -348,8 +348,6 @@ SCENARIO(
348348
new_symbol_table.lookup_ref(process_func_name);
349349
const code_typet func_code =
350350
require_type::require_code(func_symbol.type, 0);
351-
// TODO: should point to something else than Object?? - possibly
352-
// connected to bounds - issue TG-1286
353351
THEN("It has return type pointing to java.lang.Object")
354352
{
355353
require_type::require_pointer(

unit/java_bytecode/java_bytecode_parse_generics/parse_generic_wildcard_function.cpp

+4-5
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,6 @@
99
#include <testing-utils/catch.hpp>
1010
#include <testing-utils/load_java_class.h>
1111

12-
#include <util/config.h>
13-
#include <util/language.h>
14-
15-
#include <java_bytecode/java_bytecode_language.h>
16-
1712
SCENARIO(
1813
"parse_generic_wildcard",
1914
"[core][java_bytecode][java_bytecode_parse_generics]")
@@ -31,6 +26,7 @@ SCENARIO(
3126
class_prefix + func_name + func_descriptor;
3227

3328
REQUIRE(new_symbol_table.has_symbol(process_func_name));
29+
// TODO extend tests when wildcards are parsed correctly - TG-675
3430
}
3531

3632
THEN("There should be a symbol for processUpperBoundInterfaceGeneric")
@@ -41,6 +37,7 @@ SCENARIO(
4137
class_prefix + func_name + func_descriptor;
4238

4339
REQUIRE(new_symbol_table.has_symbol(process_func_name));
40+
// TODO extend tests when wildcards are parsed correctly - TG-675
4441
}
4542

4643
THEN("There should be a symbol for processUpperBoundClassGeneric")
@@ -51,6 +48,7 @@ SCENARIO(
5148
class_prefix + func_name + func_descriptor;
5249

5350
REQUIRE(new_symbol_table.has_symbol(process_func_name));
51+
// TODO extend tests when wildcards are parsed correctly - TG-675
5452
}
5553

5654
THEN("There should be a symbol for processLowerBoundGeneric")
@@ -62,5 +60,6 @@ SCENARIO(
6260
class_prefix + func_name + func_descriptor;
6361

6462
REQUIRE(new_symbol_table.has_symbol(process_func_name));
63+
// TODO extend tests when wildcards are parsed correctly - TG-675
6564
}
6665
}

0 commit comments

Comments
 (0)