Merge pull request diffblue#147 from diffblue/nathan/cleanup/summary-style

Style in summary classes

Author: NathanJPhillips

src/pointer-analysis/local_value_set_analysis.h

@@ -19,6 +19,13 @@ Author: Chris Smowton, [email protected]
 class lvsaa_single_external_set_summaryt:public summaryt
 {
  public:
+  lvsaa_single_external_set_summaryt()=default;
+
+  lvsaa_single_external_set_summaryt(
+    lvsaa_single_external_set_summaryt &&)=default;
+  lvsaa_single_external_set_summaryt &operator=(
+    lvsaa_single_external_set_summaryt &&)=default;
+
   std::string kind() const noexcept override { return "lvsaa"; }
 
   struct fieldnamet
@@ -41,7 +48,7 @@ class lvsaa_single_external_set_summaryt:public summaryt
 
     void serialize(serializert &serializer);
   };
-  std::vector<std::pair<fieldnamet, exprt> > field_assignments;
+  std::vector<std::pair<fieldnamet, exprt>> field_assignments;
 
   void serialize(serializert &serializer);
 

src/summaries/summary.h

@@ -40,27 +40,28 @@ of summaries.
 \*******************************************************************/
 class summaryt
 {
+protected:
+  summaryt()=default;
+
+  summaryt(const summaryt &)=delete;
+  summaryt &operator=(const summaryt &)=delete;
+  summaryt(summaryt &&)=default;
+  summaryt &operator=(summaryt &&)=default;
+
 public:
-  summaryt() = default;
-  summaryt(const summaryt &other) = delete;
-  summaryt(summaryt &&other) = default;
-  summaryt &operator=(const summaryt &) = delete;
-  summaryt &operator=(summaryt &&) = default;
   virtual ~summaryt() {}
 
   /*******************************************************************\
    It should return globally unique identifier of a 'kind' of the
    summaries. For example, it can be a unique name of an analysis which has
    computed them.
   \*******************************************************************/
-  virtual std::string  kind() const noexcept = 0;
+  virtual std::string kind() const noexcept=0;
 
   /*******************************************************************\
    A textual human-readable description of the summaries.
   \*******************************************************************/
-  virtual std::string  description() const noexcept { return ""; }
-
-  // TODO: define other interface functions!!
+  virtual std::string description() const noexcept { return std::string(); }
 };
 
 #endif