Remove too tight precondition in evaluator that was causing an invariant violation in some cases.

NlightNFotis · NlightNFotis · commit c93dd787d6ff · 2017-11-16T14:34:02.000Z
diff --git a/src/goto-programs/interpreter_evaluate.cpp b/src/goto-programs/interpreter_evaluate.cpp
@@ -1196,8 +1196,6 @@ mp_integer interpretert::evaluate_address(
     if(expr.operands().size()!=1)
       throw "typecast expects one operand";
 
-    PRECONDITION(expr.type().id()==ID_pointer);
-
     return evaluate_address(expr.op0(), fail_quietly);
   }
   if(!fail_quietly)

Original file line number	Diff line number	Diff line change
`@@ -1196,8 +1196,6 @@ mp_integer interpretert::evaluate_address(`
`1196`	`1196`	`if(expr.operands().size()!=1)`
`1197`	`1197`	`throw "typecast expects one operand";`
`1198`	`1198`
`1199`		`- PRECONDITION(expr.type().id()==ID_pointer);`
`1200`		`-`
`1201`	`1199`	`return evaluate_address(expr.op0(), fail_quietly);`
`1202`	`1200`	`}`
`1203`	`1201`	`if(!fail_quietly)`