Skip to content

Commit bf86af4

Browse files
author
thk123
committed
Correcting review comments
1 parent 44153b7 commit bf86af4

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

src/java_bytecode/java_bytecode_convert_method.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -386,7 +386,6 @@ void java_bytecode_convert_methodt::convert(
386386

387387
// Obtain a std::vector of code_typet::parametert objects from the
388388
// (function) type of the symbol
389-
390389
code_typet code_type = to_code_type(method_symbol.type);
391390
code_type.set(ID_C_class, class_symbol.name);
392391
method_return_type=code_type.return_type();
@@ -544,8 +543,8 @@ void java_bytecode_convert_methodt::convert(
544543
}
545544
else
546545
{
547-
method_symbol.pretty_name =
548-
id2string(class_symbol.pretty_name) + "." + id2string(m.base_name) + "()";
546+
method_symbol.pretty_name = id2string(class_symbol.pretty_name) + "." +
547+
id2string(method_symbol.base_name) + "()";
549548
}
550549

551550
method_symbol.type = code_type;

unit/java_bytecode/java_bytecode_convert_method/convert_initalizers.cpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
/*******************************************************************\
22
3-
Module: Unit tests for converting abstract classes
3+
Module: Unit tests for converting constructors and static initializers
44
5-
Author: DiffBlue Limited. All rights reserved.
5+
Author: DiffBlue Limited.
66
77
\*******************************************************************/
88

@@ -42,8 +42,10 @@ void require_is_constructor(const test_datat &test_data)
4242
/// Verify that a given descriptor is not marked as a constructor in the symbol
4343
/// table
4444
/// \param test_data The data to run the test on
45-
void require_is_static_initalizer(const test_datat &test_data)
45+
void require_is_static_initializer(const test_datat &test_data)
4646
{
47+
REQUIRE(
48+
test_data.constructor_descriptor.find("<clinit>") != std::string::npos);
4749
const symbolt &constructor =
4850
test_data.symbol_table.lookup_ref(test_data.constructor_descriptor);
4951
THEN("The constructor should be marked as a constructor")

0 commit comments

Comments
 (0)