Improve call graph unit tests

Author: smowton

unit/analyses/call_graph.cpp

@@ -11,6 +11,7 @@ Module: Unit test for call graph generation
 #include <testing-utils/catch.hpp>
 
 #include <analyses/call_graph.h>
+#include <analyses/call_graph_helpers.h>
 
 #include <util/symbol_table.h>
 #include <util/std_code.h>
@@ -160,12 +161,24 @@ SCENARIO("call_graph",
       }
     }
 
+    WHEN("A call-graph is constructed rooted at B")
+    {
+      call_grapht call_graph_from_b =
+        call_grapht::create_from_root_function(goto_model, "B", false);
+      THEN("We expect only B -> C and B -> D in the resulting graph")
+      {
+        const auto &check_graph=call_graph_from_b.graph;
+        REQUIRE(check_graph.size()==2);
+        REQUIRE(multimap_key_matches(check_graph, "B", {"C", "D"}));
+      }
+    }
+
     WHEN("The call graph is exported as a grapht")
     {
-      call_grapht::directed_call_grapht exported=
+      call_grapht::directed_grapht exported=
         call_graph_from_goto_functions.get_directed_graph();
 
-      typedef call_grapht::directed_call_grapht::node_indext node_indext;
+      typedef call_grapht::directed_grapht::node_indext node_indext;
       std::map<irep_idt, node_indext> nodes_by_name;
       for(node_indext i=0; i<exported.size(); ++i)
         nodes_by_name[exported[i].function]=i;
@@ -179,15 +192,51 @@ SCENARIO("call_graph",
         REQUIRE(exported.has_edge(nodes_by_name["B"], nodes_by_name["C"]));
         REQUIRE(exported.has_edge(nodes_by_name["B"], nodes_by_name["D"]));
       }
+
+      THEN("We expect A to have successors {A, B}")
+      {
+        std::set<irep_idt> successors = get_callees(exported, "A");
+        REQUIRE(successors.size() == 2);
+        REQUIRE(successors.count("A"));
+        REQUIRE(successors.count("B"));
+      }
+
+      THEN("We expect C to have predecessors {B}")
+      {
+        std::set<irep_idt> predecessors = get_callers(exported, "C");
+        REQUIRE(predecessors.size() == 1);
+        REQUIRE(predecessors.count("B"));
+      }
+
+      THEN("We expect all of {A, B, C, D} to be reachable from A")
+      {
+        std::set<irep_idt> successors =
+          get_reachable_functions(exported, "A");
+        REQUIRE(successors.size() == 4);
+        REQUIRE(successors.count("A"));
+        REQUIRE(successors.count("B"));
+        REQUIRE(successors.count("C"));
+        REQUIRE(successors.count("D"));
+      }
+
+      THEN("We expect {D, B, A} to be able to reach D")
+      {
+        std::set<irep_idt> predecessors =
+          get_reaching_functions(exported, "D");
+        REQUIRE(predecessors.size() == 3);
+        REQUIRE(predecessors.count("A"));
+        REQUIRE(predecessors.count("B"));
+        REQUIRE(predecessors.count("D"));
+      }
     }
 
     WHEN("The call graph, with call sites, is exported as a grapht")
     {
       call_grapht call_graph_from_goto_functions(goto_model, true);
-      call_grapht::directed_call_grapht exported=
+      call_grapht::directed_grapht exported=
         call_graph_from_goto_functions.get_directed_graph();
 
-      typedef call_grapht::directed_call_grapht::node_indext node_indext;
+      typedef call_grapht::directed_grapht::node_indext node_indext;
       std::map<irep_idt, node_indext> nodes_by_name;
       for(node_indext i=0; i<exported.size(); ++i)
         nodes_by_name[exported[i].function]=i;