Symbol-table writer: fix use of map key after erasure

smowton · smowton · commit 81bb39c11ee3 · 2017-10-26T08:24:49.000+01:00
This was revealed by re-enabling the OSX build, which evidently is quicker
to re-use the memory formerly occupied by the pair&lt;key, value&gt;!
diff --git a/src/util/symbol_table_writer.h b/src/util/symbol_table_writer.h
@@ -129,8 +129,9 @@ class journalling_symbol_table_writert
 
   void erase(const symbol_tablet::symbolst::const_iterator &entry)
   {
+    const irep_idt entry_name=entry->first;
     base_symbol_table.erase(entry);
-    on_remove(entry->first);
+    on_remove(entry_name);
   }
 
   void clear()

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,9 @@ class journalling_symbol_table_writert`
`129`	`129`
`130`	`130`	`void erase(const symbol_tablet::symbolst::const_iterator &entry)`
`131`	`131`	`{`
	`132`	`+ const irep_idt entry_name=entry->first;`
`132`	`133`	`base_symbol_table.erase(entry);`
`133`		`- on_remove(entry->first);`
	`134`	`+ on_remove(entry_name);`
`134`	`135`	`}`
`135`	`136`
`136`	`137`	`void clear()`