Merge pull request diffblue#181 from diffblue/feature/tiny_clean_up_in_security_analyser

SEC-47: Tiny clean-up in security analyser.

Author: NathanJPhillips

src/taint-analysis/taint_summary.cpp

@@ -1510,8 +1510,7 @@ void taint_algorithm_computing_summary_of_functiont::
     it!=itend;
     ++it)
   {
-    goto_programt::const_targetst succs=fn_to_summarise.body.get_successors(it);
-    for(auto succit : succs)
+    for(auto succit : fn_to_summarise.body.get_successors(it))
       inst_predecessors[succit].push_back(it);
   }
 

src/taint-analysis/taint_trace_recogniser.cpp

@@ -268,10 +268,9 @@ static void  taint_collect_successors_inside_function(
       goto_model.goto_functions.function_map.at(
           elem.get_name_of_function()
           );
-  goto_programt::const_targetst  succ_targets=
-    fn.body.get_successors(elem.get_instruction_iterator());
   std::unordered_set<std::size_t> processed_locations;
-  for(goto_programt::const_targett succ_target : succ_targets)
+  for(goto_programt::const_targett succ_target :
+      fn.body.get_successors(elem.get_instruction_iterator()))
   {
     if (0UL == trace.count(elem.get_name_of_function(),succ_target) &&
         0UL == processed_locations.count(succ_target->location_number))
@@ -369,8 +368,7 @@ static void populate_local_distances_to_taint_sink(
   std::map<instruction_iteratort, std::list<instruction_iteratort> > preds;
   for(auto it=prog.instructions.begin(),itend=prog.instructions.end(); it!=itend; ++it)
   {
-    std::list<instruction_iteratort> succs=prog.get_successors(it);
-    for(auto succ : succs)
+    for(auto succ : prog.get_successors(it))
       preds[succ].push_back(it);    
   }