cpplint

Author: marek-trtik

src/summaries/summary_dump.cpp

@@ -235,21 +235,19 @@ std::string dump_function_body_in_html(
           "    <th>Index</th>\n"
           "    <th>Name</th>\n"
           "    <th>Type</th>\n"
-          "  </tr>\n"
-          ;
+          "  </tr>\n";
   assert(ns.get_symbol_table().has_symbol(raw_fn_name));
   const symbolt &fn_symbol=ns.lookup(raw_fn_name);
   const code_typet &fn_type=to_code_type(fn_symbol.type);
-  for (std::size_t i=0UL, n=fn_type.parameters().size(); i!=n; ++i)
+  for(std::size_t i=0UL, n=fn_type.parameters().size(); i!=n; ++i)
   {
     const code_typet::parametert &param=fn_type.parameters().at(i);
     ostr << "  <tr>\n"
             "    <td>" << i << "</td>\n"
             "    <td>" << param.get_base_name() << "</td>\n"
             "    <td>" << to_html_text(from_type(ns,"",param.type()))
                        << "</td>\n"
-            "  </tr>\n"
-            ;
+            "  </tr>\n";
   }
   ostr << "</table>\n";
 
@@ -290,7 +288,7 @@ std::string dump_function_body_in_html(
 
     // Dumping instruction
     ostr << "    <td>\n";
-    dump_instruction_code_in_html(*it,ns,ostr);
+    dump_instruction_code_in_html(*it, ns, ostr);
     ostr << "</td>\n";
 
     // Dumping labels
@@ -439,7 +437,7 @@ std::string  dump_symbol_table_symbols_in_html(
 {
   fileutl_create_directory(fileutl_parse_path_in_pathname(pathname));
   std::fstream  ostr(pathname, std::ios_base::out);
-  if (!ostr.is_open())
+  if(!ostr.is_open())
       return msgstream() << "ERROR: dump_symbol_table_symbols_in_html() : "
                             "Cannot open the symbol-table-symbols log file '"
                          << pathname << "'.";
@@ -451,11 +449,11 @@ std::string  dump_symbol_table_symbols_in_html(
            "    <th>Symbol name</th>\n"
            "    <th>Properties</th>\n"
            "  </tr>\n";
-  std::map<std::string,irep_idt> sorted_keys;
-  for (const auto &name_props : symbol_table.symbols)
+  std::map<std::string, irep_idt> sorted_keys;
+  for(const auto &name_props : symbol_table.symbols)
     sorted_keys.insert({to_html_text(as_string(name_props.first)),
                         name_props.first});
-  for (const auto &name_key : sorted_keys)
+  for(const auto &name_key : sorted_keys)
   {
     const symbolt &symbol=symbol_table.symbols.at(name_key.second);
     ostr << "  <tr>\n";
@@ -496,7 +494,7 @@ std::string  dump_symbol_table_symbols_in_html(
     ostr << "        <tr>\n";
     ostr << "          <td>Type of symbol</td>\n";
     ostr << "          <td>"
-          << to_html_text(from_type(namespacet(symbol_table),"",symbol.type))
+          << to_html_text(from_type(namespacet(symbol_table), "", symbol.type))
           << "</td>\n";
     ostr << "        </tr>\n";
     ostr << "        <tr>\n";
@@ -505,7 +503,8 @@ std::string  dump_symbol_table_symbols_in_html(
     if(symbol.value.id()==ID_code)
       ostr << "&lt;function-body&gt;";
     else
-      ostr << to_html_text(from_expr(namespacet(symbol_table),"",symbol.value));
+      ostr << to_html_text(from_expr(namespacet(symbol_table), "",
+                                     symbol.value));
     ostr << "</td>\n";
     ostr << "        </tr>\n";
     ostr << "      </table>\n";
@@ -524,19 +523,19 @@ std::string dump_symbol_table_base_map_in_html(
 {
   fileutl_create_directory(fileutl_parse_path_in_pathname(pathname));
   std::fstream  ostr(pathname, std::ios_base::out);
-  if (!ostr.is_open())
+  if(!ostr.is_open())
       return msgstream() << "ERROR: dump_symbol_table_base_map_in_html() : "
                             "Cannot open the symbol-table-base-map log file '"
                          << pathname << "'.";
 
-  dump_html_prefix(ostr,"Symbol table base");
+  dump_html_prefix(ostr, "Symbol table base");
   ostr << "<h2>Content of multimap 'symbol_tablet::symbol_base_map'.</h2>\n";
   ostr << "<table>\n"
            "  <tr>\n"
            "    <th>Key</th>\n"
            "    <th>Value</th>\n"
            "  </tr>\n";
-  for (const auto &name_base : base_map)
+  for(const auto &name_base : base_map)
   {
     ostr << "  <tr>\n";
     ostr << "    <td>" << name_base.first << "</td>\n"
@@ -555,20 +554,20 @@ std::string dump_symbol_table_module_map_in_html(
 {
   fileutl_create_directory(fileutl_parse_path_in_pathname(pathname));
   std::fstream  ostr(pathname, std::ios_base::out);
-  if (!ostr.is_open())
+  if(!ostr.is_open())
       return msgstream() << "ERROR: dump_symbol_table_module_map_in_html() : "
                             "Cannot open the symbol-table-module-map log "
                             "file '"
                          << pathname << "'.";
-  dump_html_prefix(ostr,"Symbol table module");
+  dump_html_prefix(ostr, "Symbol table module");
   ostr << "<h2>Content of multimap 'symbol_tablet::symbol_module_map'."
            "</h2>\n";
   ostr << "<table>\n"
            "  <tr>\n"
            "    <th>Key</th>\n"
            "    <th>Value</th>\n"
            "  </tr>\n";
-  for (const auto &name_module : module_map)
+  for(const auto &name_module : module_map)
   {
     ostr << "  <tr>\n";
     ostr << "    <td>" << name_module.first << "</td>\n"
@@ -631,16 +630,16 @@ std::string dump_symbol_table_in_html(
 {
   fileutl_create_directory(dump_root_directory);
   const std::string pathname=
-    fileutl_concatenate_file_paths(dump_root_directory,"symbol_table.html");
-  std::fstream  ostr(pathname,std::ios_base::out);
-  if (!ostr.is_open())
+    fileutl_concatenate_file_paths(dump_root_directory, "symbol_table.html");
+  std::fstream ostr(pathname, std::ios_base::out);
+  if(!ostr.is_open())
       return msgstream() << "ERROR: dump_symbol_table_in_html() : "
                             "Cannot open the symbol-table log file '"
                          << pathname << "'.";
-  dump_html_prefix(ostr,"Symbol table module");
+  dump_html_prefix(ostr, "Symbol table module");
   ostr << "<h3>Symbol table</h3>\n";
   std::string error=
-    dump_symbol_table_as_html_table(symbol_table,dump_root_directory,ostr);
+    dump_symbol_table_as_html_table(symbol_table, dump_root_directory, ostr);
   if(!error.empty())
     return error;
   dump_html_suffix(ostr);
@@ -708,7 +707,7 @@ std::string  dump_goto_program_in_html(
   ostr << "<h3>Symbol table</h3>\n";
 
   std::string error=
-    dump_symbol_table_as_html_table(symbol_table,dump_root_directory,ostr);
+    dump_symbol_table_as_html_table(symbol_table, dump_root_directory, ostr);
   if(!error.empty())
     return error;
 
@@ -721,11 +720,11 @@ std::string  dump_goto_program_in_html(
     std::string const  cg_file =
         msgstream() << dump_root_directory << "/call_graph.html";
     std::fstream  cg_ostr(cg_file, std::ios_base::out);
-    if (!cg_ostr.is_open())
+    if(!cg_ostr.is_open())
         return msgstream() << "ERROR: sumfn::dump_goto_program_in_html() : "
                               "Cannot open the call-graph log file '"
                            << cg_file << "'.";
-    dump_html_prefix(cg_ostr,"Call Graph");
+    dump_html_prefix(cg_ostr, "Call Graph");
     cg_ostr << "<img style=\"max-width: 1920px;\" "
                "src=\"./call_graph.svg\" alt=\"call graph SVG file\">\n";
     dump_html_suffix(cg_ostr);
@@ -745,16 +744,16 @@ std::string  dump_goto_program_in_html(
   {
     std::string const  class_hierarchy_svg_file =
         msgstream() << dump_root_directory << "/class_hierarchy.svg";
-    dump_classhierarchy_in_svg(class_hierarchy,class_hierarchy_svg_file);
+    dump_classhierarchy_in_svg(class_hierarchy, class_hierarchy_svg_file);
 
     std::string const  ch_file =
         msgstream() << dump_root_directory << "/class_hierarchy.html";
     std::fstream  ch_ostr(ch_file, std::ios_base::out);
-    if (!ch_ostr.is_open())
+    if(!ch_ostr.is_open())
         return msgstream() << "ERROR: sumfn::dump_goto_program_in_html() : "
                               "Cannot open the class-hierarchy log file '"
                            << ch_file << "'.";
-    dump_html_prefix(ch_ostr,"Class Hierarchy");
+    dump_html_prefix(ch_ostr, "Class Hierarchy");
     ch_ostr << "<img style=\"max-width: 1920px;\" "
                "src=\"./class_hierarchy.svg\" "
                "alt=\"class hierarchy SVG file\">\n";
@@ -774,7 +773,7 @@ std::string  dump_goto_program_in_html(
   ostr << "<h3>Inverted (partial) topological order of functions (i.e. "
           "from callees to callers):</h3>\n";
   ostr << "<ul>\n";
-  for (irep_idt const&  fn_name : inverted_functions_topological_order)
+  for(irep_idt const&  fn_name : inverted_functions_topological_order)
     ostr << "<li>" << to_html_text(as_string(fn_name)) << "</li>\n";
   ostr << "</ul>\n";
 
@@ -794,43 +793,40 @@ std::string  dump_goto_functions_in_html(
     if(it->second.body_available())
     {
       std::string err_message =
-          dump_function_body_in_html(
-              it->first,
-              it->second.body,
-              ns,
-              fileutl_concatenate_file_paths(
-                dump_root_directory,to_file_name(as_string(it->first)))
-              );
-      if (!err_message.empty())
+        dump_function_body_in_html(
+          it->first,
+          it->second.body,
+          ns,
+          fileutl_concatenate_file_paths(
+            dump_root_directory, to_file_name(as_string(it->first))));
+      if(!err_message.empty())
         return err_message;
     }
 
   const std::string log_filename =
       msgstream() << dump_root_directory << "/index.html";
   std::fstream ostr(log_filename, std::ios_base::out);
-  if (!ostr.is_open())
+  if(!ostr.is_open())
       return msgstream() << "ERROR: sumfn::dump_goto_functions_in_html() : "
-                            "Cannot open the log file '" << log_filename << "'."
-                         ;
-  dump_html_prefix(ostr,"Functions");
+                            "Cannot open the log file '" << log_filename
+                         << "'.";
+  dump_html_prefix(ostr, "Functions");
   ostr << "<h3>Listing of functions</h3>\n";
   ostr << "<table>\n"
           "  <tr>\n"
           "    <th>Function name</th>\n"
           "    <th>Code</th>\n"
-          "  </tr>\n"
-          ;
-  std::set<std::string>  ordered;
+          "  </tr>\n";
+  std::set<std::string> ordered;
   for(auto it=functions.cbegin(); it!=functions.cend(); ++it)
     if(it->second.body_available())
       ordered.insert(as_string(it->first));
-  for (const auto &fn_name : ordered)
+  for(const auto &fn_name : ordered)
       ostr << "  <tr>\n"
               "    <td>" << to_html_text(fn_name) << "</td>\n"
               "    <td><a href=\"./" << to_file_name(fn_name)
                                      << "/index.html\">here</a></td>\n"
-              "  </tr>\n"
-              ;
+              "  </tr>\n";
   ostr << "</table>\n";
   dump_html_suffix(ostr);
   return ""; // no error.