prefer a ranged for over indexed iteration

Author: Daniel Kroening

src/goto-symex/symex_function_call.cpp

@@ -282,8 +282,8 @@ void goto_symext::symex_function_call_code(
 
   // read the arguments -- before the locality renaming
   exprt::operandst arguments=call.arguments();
-  for(unsigned i=0; i<arguments.size(); i++)
-    state.rename(arguments[i], ns);
+  for(auto &a : arguments)
+    state.rename(a, ns);
 
   // produce a new frame
   assert(!state.call_stack().empty());

src/java_bytecode/java_types.cpp

@@ -241,9 +241,9 @@ typet java_type_from_string(const std::string &src)
         return nil_typet();
       std::string class_name=src.substr(1, src.size()-2);
 
-      for(unsigned i=0; i<class_name.size(); i++)
-        if(class_name[i]=='/')
-          class_name[i]='.';
+      for(auto &letter : class_name)
+        if(letter=='/')
+          letter='.';
 
       std::string identifier="java::"+class_name;
       symbol_typet symbol_type(identifier);

src/langapi/language_ui.cpp

@@ -37,11 +37,9 @@ language_uit::~language_uit()
 
 bool language_uit::parse()
 {
-  for(unsigned i=0; i<_cmdline.args.size(); i++)
-  {
-    if(parse(_cmdline.args[i]))
+  for(const auto &filename : _cmdline.args)
+    if(parse(filename))
       return true;
-  }
 
   return false;
 }

src/memory-models/mm2cpp.cpp

@@ -37,9 +37,8 @@ std::string mm2cppt::text2c(const irep_idt &src)
   std::string result;
   result.reserve(src.size());
 
-  for(unsigned i=0; i<src.size(); i++)
+  for(const auto ch : id2string(src))
   {
-    char ch=src[i];
     if(isalnum(ch))
       result+=ch;
     else