Make use of move semantics for parameters where possible

Author: NathanJPhillips

src/util/string_join.h

@@ -54,8 +54,11 @@ class joined_strings
       ostringstream_typet;
 
   public:
-    joined_strings(It begin, const It end, const Str &sep)
-      : begin(begin), end(end), sep(sep)
+    template<typename It_In, typename Str_In>
+    joined_strings(It_In &&begin, It_In &&end, Str_In &&sep)
+      : begin(std::forward<It_In>(begin)),
+        end(std::forward<It_In>(end)),
+        sep(std::forward<Str_In>(sep))
     {
     }
 
@@ -84,16 +87,19 @@ class joined_strings
 
 
 template<typename Str, typename It>
-inline joined_strings<Str, It> join(It begin, const It end, const Str &sep)
+inline joined_strings<Str, It> join(It begin, It end, const Str &sep)
 {
-  return joined_strings<Str, It>(begin, end, sep);
+  return joined_strings<Str, It>(std::move(begin), std::move(end), sep);
 }
 
 template<typename It>
 inline joined_strings<const char *, It> join(
-  It begin, const It end, const char *sep)
+  It begin, It end, const char *sep)
 {
-  return joined_strings<const char *, It>(begin, end, sep);
+  return joined_strings<const char *, It>(
+    std::move(begin),
+    std::move(end),
+    sep);
 }
 
 
@@ -105,10 +111,11 @@ class joined_strings_container
     Container container;
 
   public:
-    joined_strings_container(const Container &container, const Str &sep)
+    template<typename Container_In, typename Str_In>
+    joined_strings_container(Container_In &&container, Str_In &&sep)
       : joined_strings<Str, typename Container::const_iterator>(
-          container.begin(), container.end(), sep),
-        container(container)
+          container.begin(), container.end(), std::forward<Str_In>(sep)),
+        container(std::forward<Container_In>(container))
     {
     }
 };