Merge pull request diffblue#252 from diffblue/owen/tests-for-lvsa

SEC-96 Tests for LVSA precise access paths

Author: owen-jones-diffblue

regression/LVSA/TestBasic/Test.class

@@ -16,6 +16,15 @@ public void outputs_dynamic_object() {
     output = new A();
   }
 
+  public void outputs_null_or_dynamic_object(Boolean someBoolean) {
+    if (someBoolean) {
+      output = new A();
+    }
+    else {
+      output = null;
+    }
+  }
+
   public void outputs_dynamic_object_with_allocated_field() {
     output = new A();
     output.instanceObj = new Object();

regression/LVSA/TestBasic/Test.java

@@ -24,6 +24,17 @@ def test_outputs_dynamic_object(tmpdir):
     output_value_expectation.check_contains_dynamic_object()
 
 
+def test_outputs_null_or_dynamic_object(tmpdir):
+    lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('outputs_null_or_dynamic_object')
+    lvsa_expectation = lvsa_driver.run()
+
+    output_value_expectation = lvsa_expectation.check_output()
+
+    output_value_expectation.check_number_of_values(2)
+    output_value_expectation.check_contains_null_object()
+    output_value_expectation.check_contains_dynamic_object()
+
+
 def test_outputs_dynamic_object_with_allocated_field(tmpdir):
     lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('outputs_dynamic_object_with_allocated_field')
     lvsa_expectation = lvsa_driver.run()

regression/LVSA/TestBasic/test_basic.py

@@ -0,0 +1,47 @@
+package LVSA.TestPreciseAccessPaths;
+
+public class Test {
+  static Object output;
+  A left_a;
+  A right_a;
+
+  public class A {
+    Object left_object;
+    Object right_object;
+  }
+
+  // Precise access paths should work fine
+  public void field_setter(A parameter_a) {
+    output = parameter_a.left_object;
+  }
+
+  // Precise access paths should work fine
+  public Object field_getter() {
+    return left_a.left_object;
+  }
+
+  // Precise access paths should work fine
+  public void read_field_before_writing_to_aliasable_field() {
+    output = right_a.left_object;
+    left_a.left_object = new Object();
+  }
+
+  // Precise access paths must be careful that right_a.left_object could be
+  // aliased by left_a.left_object, so it might be changed by the first line,
+  // and thus we cannot just return "right_a.left_object"
+  public void read_field_after_writing_to_aliasable_field() {
+    left_a.left_object = new Object();
+    output = right_a.left_object;
+  }
+
+  // Helper function for call_function_to_allocate_new_object()
+  public void allocate_new_object(A input_A) {
+    input_A.left_object = new Object();
+  }
+
+  // Precise access paths should work fine
+  public void call_function_to_allocate_new_object(A param_A) {
+    allocate_new_object(param_A);
+    output = param_A.left_object;
+  }
+}

regression/LVSA/TestPreciseAccessPaths/Test$A.class

@@ -0,0 +1,73 @@
+from regression.LVSA.lvsa_driver import LvsaDriver
+
+
+folder_name = 'TestPreciseAccessPaths'
+
+
+def test_field_setter(tmpdir):
+    # This test should change when precise access paths have been implemented
+    lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('field_setter')
+    lvsa_expectation = lvsa_driver.run()
+
+    output_value_expectation = lvsa_expectation.check_output()
+
+    output_value_expectation.check_number_of_values(1)
+    output_value_expectation.check_contains_external_value_set()
+
+
+def test_field_getter(tmpdir):
+    # This test should change when precise access paths have been implemented
+    lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('field_getter')
+    lvsa_expectation = lvsa_driver.run()
+
+    output_value_expectation = lvsa_expectation.check_return_value()
+
+    output_value_expectation.check_number_of_values(1)
+    output_value_expectation.check_contains_external_value_set()
+
+
+def test_read_field_before_writing_to_aliasable_field(tmpdir):
+    # This test should change when precise access paths have been implemented
+    lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('read_field_before_writing_to_aliasable_field')
+    lvsa_expectation = lvsa_driver.run()
+
+    output_value_expectation_1 = lvsa_expectation.check_external_value_set('A', '.left_object')
+
+    output_value_expectation_1.check_number_of_values(2)
+    output_value_expectation_1.check_contains_external_value_set()
+    output_value_expectation_1.check_contains_dynamic_object()
+
+    output_value_expectation_2 = lvsa_expectation.check_output()
+
+    output_value_expectation_2.check_number_of_values(1)
+    output_value_expectation_2.check_contains_external_value_set()
+
+
+def test_read_field_after_writing_to_aliasable_field(tmpdir):
+    # This test should not change significantly when precise access paths have been implemented
+    lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('read_field_after_writing_to_aliasable_field')
+    lvsa_expectation = lvsa_driver.run()
+
+    output_value_expectation_1 = lvsa_expectation.check_external_value_set('A', '.left_object')
+
+    output_value_expectation_1.check_number_of_values(2)
+    output_value_expectation_1.check_contains_external_value_set()
+    output_value_expectation_1.check_contains_dynamic_object()
+
+    output_value_expectation_2 = lvsa_expectation.check_output()
+
+    output_value_expectation_2.check_number_of_values(2)
+    output_value_expectation_2.check_contains_external_value_set()
+    output_value_expectation_2.check_contains_dynamic_object()
+
+
+def test_call_function_to_allocate_new_object(tmpdir):
+    # This test should change when precise access paths have been implemented
+    lvsa_driver = LvsaDriver(tmpdir, folder_name).with_test_function('call_function_to_allocate_new_object')
+    lvsa_expectation = lvsa_driver.run()
+
+    output_value_expectation = lvsa_expectation.check_output()
+
+    output_value_expectation.check_number_of_values(2)
+    output_value_expectation.check_contains_external_value_set()
+    output_value_expectation.check_contains_dynamic_object()