Add service client doc generator only when typedoc is selected (#1253)

Author: trivikr

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/PackageJsonGenerator.java

@@ -77,6 +77,14 @@ static void writePackageJson(
                 node = node.withMember("devDependencies", devDeps);
             }
 
+            // Add @smithy/service-client-documentation-generator to the "devDependencies" if not present
+            if (devDeps.getMember(TypeScriptDependency.AWS_SDK_CLIENT_DOCGEN.packageName).isEmpty()) {
+                devDeps = devDeps.withMember(
+                    TypeScriptDependency.AWS_SDK_CLIENT_DOCGEN.packageName,
+                    TypeScriptDependency.AWS_SDK_CLIENT_DOCGEN.version);
+                node = node.withMember("devDependencies", devDeps);
+            }
+
             // Add build:docs script
             ObjectNode scripts = node.getObjectMember("scripts").orElse(Node.objectNode());
             scripts = scripts.withMember("build:docs", "typedoc");

smithy-typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptDependency.java

@@ -39,7 +39,7 @@
 public enum TypeScriptDependency implements Dependency {
 
     SMITHY_CORE("dependencies", "@smithy/core", false),
-    AWS_SDK_CLIENT_DOCGEN("devDependencies", "@smithy/service-client-documentation-generator", true),
+    AWS_SDK_CLIENT_DOCGEN("devDependencies", "@smithy/service-client-documentation-generator", false),
     AWS_SDK_TYPES("dependencies", "@aws-sdk/types", true),
     SMITHY_TYPES("dependencies", "@smithy/types", true),
     AWS_SMITHY_CLIENT("dependencies", "@smithy/smithy-client", true),

smithy-typescript-codegen/src/test/java/software/amazon/smithy/typescript/codegen/TypeScriptDependencyTest.java

@@ -26,7 +26,7 @@ public void createsSymbols() {
     @Test
     public void getsUnconditionalDependencies() {
         assertThat(TypeScriptDependency.getUnconditionalDependencies(),
-                   hasItem(TypeScriptDependency.AWS_SDK_CLIENT_DOCGEN.dependency));
+                   hasItem(TypeScriptDependency.SMITHY_TYPES.dependency));
     }
 
     @Test