Replace conditionals with range-containment

jjant · jjant · commit aaf14f33eeee · 2022-10-07T12:04:55.000+01:00
diff --git a/rust-runtime/aws-smithy-types/src/lib.rs b/rust-runtime/aws-smithy-types/src/lib.rs
@@ -291,7 +291,7 @@ impl TryFrom<Number> for f64 {
                 }
             }
             Number::NegInt(v) => {
-                if -(1 << 53) <= v && v <= (1 << 53) {
+                if (-(1 << 53)..=(1 << 53)).contains(&v) {
                     Ok(v as Self)
                 } else {
                     Err(Self::Error::I64ToFloatLossyConversion(v))
@@ -316,7 +316,7 @@ impl TryFrom<Number> for f32 {
                 }
             }
             Number::NegInt(v) => {
-                if -(1 << 24) <= v && v <= (1 << 24) {
+                if (-(1 << 24)..=(1 << 24)).contains(&v) {
                     Ok(v as Self)
                 } else {
                     Err(Self::Error::I64ToFloatLossyConversion(v))

Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ impl TryFrom<Number> for f64 {`
`291`	`291`	`}`
`292`	`292`	`}`
`293`	`293`	`Number::NegInt(v) => {`
`294`		`- if -(1 << 53) <= v && v <= (1 << 53) {`
	`294`	`+ if (-(1 << 53)..=(1 << 53)).contains(&v) {`
`295`	`295`	`Ok(v as Self)`
`296`	`296`	`} else {`
`297`	`297`	`Err(Self::Error::I64ToFloatLossyConversion(v))`
`@@ -316,7 +316,7 @@ impl TryFrom<Number> for f32 {`
`316`	`316`	`}`
`317`	`317`	`}`
`318`	`318`	`Number::NegInt(v) => {`
`319`		`- if -(1 << 24) <= v && v <= (1 << 24) {`
	`319`	`+ if (-(1 << 24)..=(1 << 24)).contains(&v) {`
`320`	`320`	`Ok(v as Self)`
`321`	`321`	`} else {`
`322`	`322`	`Err(Self::Error::I64ToFloatLossyConversion(v))`