Skip to content

Commit ac7a2aa

Browse files
authored
Merge pull request scala#7803 from retronym/topic/find-classloader-access
Fix access of extension point for macro classloaders
2 parents c742cff + 2d2676d commit ac7a2aa

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/compiler/scala/tools/nsc/plugins/Plugins.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ trait Plugins { global: Global =>
175175
*
176176
* Mirrors with runtime definitions (e.g. Repl) need to adjust this method.
177177
*/
178-
protected[scala] def findMacroClassLoader(): ClassLoader = {
178+
def findMacroClassLoader(): ClassLoader = {
179179
val classpath: Seq[URL] = if (settings.YmacroClasspath.isSetByUser) {
180180
for {
181181
file <- scala.tools.nsc.util.ClassPath.expandPath(settings.YmacroClasspath.value, true)

src/compiler/scala/tools/reflect/ReflectGlobal.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class ReflectGlobal(currentSettings: Settings, reporter: Reporter, override val
3030
* Macro expansion can use everything available in `global.classPath` or `rootClassLoader`.
3131
* The `rootClassLoader` is used to obtain runtime defined macros.
3232
*/
33-
override protected[scala] def findMacroClassLoader(): ClassLoader = {
33+
override def findMacroClassLoader(): ClassLoader = {
3434
val classpath = classPath.asURLs
3535
perRunCaches.recordClassloader(ScalaClassLoader.fromURLs(classpath, rootClassLoader))
3636
}

src/repl/scala/tools/nsc/interpreter/ReplGlobal.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ trait ReplGlobal extends Global {
2525
super.abort(msg)
2626
}
2727

28-
override protected[scala] def findMacroClassLoader(): ClassLoader = {
28+
override def findMacroClassLoader(): ClassLoader = {
2929
val loader = super.findMacroClassLoader
3030
analyzer.macroLogVerbose("macro classloader: initializing from a REPL classloader: %s".format(classPath.asURLs))
3131
val virtualDirectory = analyzer.globalSettings.outputDirs.getSingleOutput.get

test/junit/scala/tools/nsc/GlobalCustomizeClassloaderTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class GlobalCustomizeClassloaderTest {
2626
}
2727

2828
val g = new Global(new Settings) {
29-
override protected[scala] def findMacroClassLoader(): ClassLoader = new URLClassLoader(Nil, getClass.getClassLoader){
29+
override def findMacroClassLoader(): ClassLoader = new URLClassLoader(Nil, getClass.getClassLoader){
3030
override def close(): Unit = closeUnexpected()
3131
}
3232
override protected def findPluginClassLoader(classpath: Seq[Path]): ClassLoader = {

0 commit comments

Comments
 (0)