Move the inlining of value class methods before Erasure

VCInline is split into two phases:
- VCInlineMethods (before Erasure) replaces value class method calls
  by calls to extension methods
- VCInlineEqAndField (after Erasure) handles == and the underlying field
  of a value class, as VCInline did before.

This should not affect anything currently, but in the future we will have
phases before Erasure that mangle names (like TypeSpecializer, see scala#630),
being able to put these phases after VCInlineMethods means that
VCInlineMethods does not need to know anything about how these phases
mangle names, this reduces the coupling between phases. The trade-off is
that VCInlineMethods needs to deal with type parameters and multiple
parameter lists whereas VCInline didn't.

Author: smarter

src/dotty/tools/dotc/Compiler.scala

@@ -51,7 +51,8 @@ class Compiler {
       List(new PatternMatcher,
            new ExplicitOuter,
            new Splitter),
-      List(new SeqLiterals,
+      List(new VCInlineMethods),
+           List(new SeqLiterals,
            new InterceptedMethods,
            new Literalize,
            new Getters,
@@ -61,7 +62,7 @@ class Compiler {
            new ResolveSuper),
       List(new Erasure),
       List(new ElimErasedValueType,
-           new VCInline,
+           new VCInlineEqAndField,
            new Mixin,
            new LazyVals,
            new Memoize,

src/dotty/tools/dotc/transform/VCInline.scala renamed to src/dotty/tools/dotc/transform/VCInlineEqAndField.scala

@@ -7,20 +7,18 @@ import Contexts._, Trees._, StdNames._, Symbols._
 import DenotTransformers._, TreeTransforms._, Phases.Phase
 import ExtensionMethods._, TreeExtractors._, ValueClasses._
 
-/** This phase inlines calls to methods and fields of value classes.
+/** This phase inlines calls to == and to the field of a value class
  *
  *  For a value class V defined as:
- *    case class V(val underlying: U) extends AnyVal
- *  We replace method calls by calls to the corresponding extension method:
- *    v.foo(args) => V.foo$extension(v.underlying(), args)
- *  And we avoid unnecessary allocations:
+ *    class V(val underlying: U) extends AnyVal
+ *  we avoid unnecessary allocations:
  *     new V(u1) == new V(u2) => u1 == u2
  *    (new V(u)).underlying() => u
  */
-class VCInline extends MiniPhaseTransform with IdentityDenotTransformer {
+class VCInlineEqAndField extends MiniPhaseTransform with IdentityDenotTransformer {
   import tpd._
 
-  override def phaseName: String = "vcInline"
+  override def phaseName: String = "vcInlineEqAndField"
 
   override def runsAfter: Set[Class[_ <: Phase]] = Set(classOf[ElimErasedValueType])
 
@@ -37,22 +35,6 @@ class VCInline extends MiniPhaseTransform with IdentityDenotTransformer {
       case ValueClassUnbox(NewWithArgs(_, List(u))) =>
         u
 
-      // (new V(u)).foo(args) => V.foo$extension(u, args)
-      //          v.foo(args) => V.foo$extension(v.underlying(), args)
-      case Apply(sel @ Select(receiver, _), args) =>
-        val classMeth = sel.symbol
-        if (isMethodWithExtension(classMeth)) {
-          val classSym = receiver.tpe.widenDealias.typeSymbol.asClass
-          val unboxedReceiver = receiver match {
-            case NewWithArgs(_, List(u)) =>
-              u
-            case _ =>
-              receiver.select(valueClassUnbox(classSym)).appliedToNone
-          }
-          val extensionMeth = extensionMethod(classMeth)
-          ref(extensionMeth).appliedToArgs(unboxedReceiver :: args)
-        } else tree
-
       case _ =>
         tree
     }

src/dotty/tools/dotc/transform/VCInlineMethods.scala

@@ -0,0 +1,117 @@
+package dotty.tools.dotc
+package transform
+
+import ast.{Trees, tpd}
+import core._, core.Decorators._
+import Contexts._, Trees._, Types._
+import DenotTransformers._, TreeTransforms._, Phases.Phase
+import ExtensionMethods._, ValueClasses._
+
+import collection.mutable.ListBuffer
+
+/** This phase inlines calls to methods of value classes.
+ *
+ *  A value class V after [[ExtensionMethods]] will look like:
+ *    class V[A, B, ...](val underlying: U) extends AnyVal {
+ *      def foo[T, S, ...](arg1: A1, arg2: A2, ...) =
+ *        V.foo$extension[T, S, ..., A, B, ...](this)(arg1, arg2, ...)
+ *
+ *       ...
+ *    }
+ *
+ *  Let e have type V, if e is a stable prefix or if V does not have any class
+ *  type parameter, then we can rewrite:
+ *    e.foo[X, Y, ...](args)
+ *  as:
+ *    V.foo$extension[X, Y, ..., e.A, e.B, ...](e)(args)
+ *  Otherwise, we need to evaluate e first:
+ *    {
+ *      val ev = e
+ *      V.foo$extension[X, Y, ..., ev.A, ev.B, ...](ev)(args)
+ *    }
+ *
+ *  This phase needs to be placed after phases which may introduce calls to
+ *  value class methods (like [[PatternMatcher]]). This phase uses name mangling
+ *  to find the correct extension method corresponding to a value class method
+ *  (see [[ExtensionMethods.extensionMethod]]), therefore we choose to place it
+ *  before phases which may perform their own name mangling on value class
+ *  methods (like [[TypeSpecializer]]), this way [[VCInlineMethods]] does not
+ *  need to have any knowledge of the name mangling done by other phases.
+ */
+class VCInlineMethods extends MiniPhaseTransform with IdentityDenotTransformer {
+  import tpd._
+
+  override def phaseName: String = "vcInlineMethods"
+
+  override def runsAfter: Set[Class[_ <: Phase]] =
+    Set(classOf[ExtensionMethods], classOf[PatternMatcher])
+
+  /** Replace a value class method call by a call to the corresponding extension method.
+   *
+   *  @param tree   The tree corresponding to the method call
+   *  @param mtArgs Type arguments for the method call not present in `tree`
+   *  @param mArgss Arguments for the method call not present in `tree`
+   *  @return       A tree for the extension method call
+   */
+  private def rewire(tree: Tree, mtArgs: List[Tree] = Nil, mArgss: List[List[Tree]] = Nil)
+    (implicit ctx: Context): Tree =
+    tree match {
+      case Apply(qual, mArgs) =>
+        rewire(qual, mtArgs, mArgs :: mArgss)
+      case TypeApply(qual, mtArgs2) =>
+        assert(mtArgs == Nil)
+        rewire(qual, mtArgs2, mArgss)
+      case sel @ Select(qual, _) =>
+        val origMeth = sel.symbol
+        val ctParams = origMeth.enclosingClass.typeParams
+        val extensionMeth = extensionMethod(origMeth)
+
+        if (!ctParams.isEmpty) {
+          evalOnce(qual) { ev =>
+            val ctArgs = ctParams map (ev.select(_))
+            ref(extensionMeth)
+              .appliedToTypeTrees(mtArgs ++ ctArgs)
+              .appliedTo(ev)
+              .appliedToArgss(mArgss)
+          }
+        } else {
+          ref(extensionMeth)
+            .appliedToTypeTrees(mtArgs)
+            .appliedTo(qual)
+            .appliedToArgss(mArgss)
+        }
+    }
+
+  override def transformSelect(tree: Select)(implicit ctx: Context, info: TransformerInfo): Tree =
+    tree.tpe.widen match {
+      case tp: MethodOrPoly =>
+        tree // The rewiring will be handled by a fully-applied parent node
+      case _ =>
+        if (isMethodWithExtension(tree.symbol))
+          rewire(tree)
+        else
+          tree
+    }
+
+  override def transformTypeApply(tree: TypeApply)(implicit ctx: Context, info: TransformerInfo): Tree =
+    tree.tpe.widen match {
+      case tp: MethodType =>
+        tree // The rewiring will be handled by a fully-applied parent node
+      case _ =>
+        if (isMethodWithExtension(tree.symbol))
+          rewire(tree)
+        else
+          tree
+    }
+
+  override def transformApply(tree: Apply)(implicit ctx: Context, info: TransformerInfo): Tree =
+    tree.tpe.widen match {
+      case tp: MethodType =>
+        tree // The rewiring will be handled by transformApply
+      case _ =>
+        if (isMethodWithExtension(tree.symbol))
+          rewire(tree)
+        else
+          tree
+    }
+}

tests/pos/valueclasses/paramlists.scala

@@ -0,0 +1,25 @@
+package paramlists
+
+class Meter[T](val x: T) extends AnyVal {
+  def zero: T = x
+  def zero2[M >: T]: M = x
+  def one(): T = x
+  def one2[M >: T](): M = x
+  def one3(x: T): T = x
+  def one4[M >: T](x: M): M = x
+  def two(x: T)(y: T): T = y
+  def two2[M >: T](x: T)(y: M): M = y
+}
+
+object Test {
+  def test: Unit = {
+    val m1 = new Meter(1)
+    m1.zero
+    m1.zero2
+    m1.one
+    m1.one2
+    m1.one3(10)
+    m1.two(11)(12)
+    m1.two2(11)(12)
+  }
+}