Fix scala#725: Enable -Ycheck:all

smarter · smarter · commit af00d130d87e · 2018-03-24T00:41:34.000+01:00
diff --git a/compiler/src/dotty/tools/dotc/typer/Checking.scala b/compiler/src/dotty/tools/dotc/typer/Checking.scala
@@ -612,8 +612,6 @@ trait Checking {
         case tp: ConstantType if exprPurity(tree) >= purityLevel => // ok
         case tp if defn.isFunctionType(tp) && exprPurity(tree) >= purityLevel => // ok
         case _ =>
-          println("exprP: " + exprPurity(tree))
-          println("purityLevel: " + purityLevel)
           if (!ctx.erasedTypes) ctx.error(em"$what must be a constant expression or a function", tree.pos)
       }
     }
diff --git a/compiler/test/dotty/tools/vulpix/TestConfiguration.scala b/compiler/test/dotty/tools/vulpix/TestConfiguration.scala
@@ -44,8 +44,7 @@ object TestConfiguration {
     } mkString(":")
   }
 
-  // Ideally should be Ycheck:all
-  val yCheckOptions = Array("-Ycheck:elimJavaPackages,refchecks,splitter,arrayConstructors,erasure,capturedVars,getClass,elimStaticThis,labelDef")
+  val yCheckOptions = Array("-Ycheck:all")
 
   val basicDefaultOptions = checkOptions ++ noCheckOptions ++ yCheckOptions
   val defaultUnoptimised = TestFlags(classPath, runClassPath, basicDefaultOptions)

Original file line number	Diff line number	Diff line change
`@@ -612,8 +612,6 @@ trait Checking {`
`612`	`612`	`case tp: ConstantType if exprPurity(tree) >= purityLevel => // ok`
`613`	`613`	`case tp if defn.isFunctionType(tp) && exprPurity(tree) >= purityLevel => // ok`
`614`	`614`	`case _ =>`
`615`		`- println("exprP: " + exprPurity(tree))`
`616`		`- println("purityLevel: " + purityLevel)`
`617`	`615`	`if (!ctx.erasedTypes) ctx.error(em"$what must be a constant expression or a function", tree.pos)`
`618`	`616`	`}`
`619`	`617`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,8 +44,7 @@ object TestConfiguration {`
`44`	`44`	`} mkString(":")`
`45`	`45`	`}`
`46`	`46`
`47`		`- // Ideally should be Ycheck:all`
`48`		`- val yCheckOptions = Array("-Ycheck:elimJavaPackages,refchecks,splitter,arrayConstructors,erasure,capturedVars,getClass,elimStaticThis,labelDef")`
	`47`	`+ val yCheckOptions = Array("-Ycheck:all")`
`49`	`48`
`50`	`49`	`val basicDefaultOptions = checkOptions ++ noCheckOptions ++ yCheckOptions`
`51`	`50`	`val defaultUnoptimised = TestFlags(classPath, runClassPath, basicDefaultOptions)`