repl: Use the correct parent Classloader on Java 9+

smarter · smarter · commit 8c8f9c174934 · 2021-03-08T14:55:57.000+01:00
On Java 9+, `null` as a parent of a URLClassLoader means the parent is the bootstrap classloader which doesn't contain modules like `java.sql`, explicitly use the system classloader instead. Fixes scala#11646.
diff --git a/compiler/src/dotty/tools/repl/Rendering.scala b/compiler/src/dotty/tools/repl/Rendering.scala
@@ -47,7 +47,7 @@ private[repl] class Rendering(parentClassLoader: Option[ClassLoader] = None) {
     else {
       val parent = parentClassLoader.getOrElse {
         val compilerClasspath = ctx.platform.classPath(using ctx).asURLs
-        new java.net.URLClassLoader(compilerClasspath.toArray, null)
+        new java.net.URLClassLoader(compilerClasspath.toArray, ClassLoader.getSystemClassLoader)
       }
 
       myClassLoader = new AbstractFileClassLoader(ctx.settings.outputDir.value, parent)
diff --git a/compiler/test-resources/repl/defaultClassloader b/compiler/test-resources/repl/defaultClassloader
@@ -0,0 +1,3 @@
+scala> val d: java.sql.Date = new java.sql.Date(100L)
+val d: java.sql.Date = 1970-01-01
+

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ private[repl] class Rendering(parentClassLoader: Option[ClassLoader] = None) {`
`47`	`47`	`else {`
`48`	`48`	`val parent = parentClassLoader.getOrElse {`
`49`	`49`	`val compilerClasspath = ctx.platform.classPath(using ctx).asURLs`
`50`		`- new java.net.URLClassLoader(compilerClasspath.toArray, null)`
	`50`	`+ new java.net.URLClassLoader(compilerClasspath.toArray, ClassLoader.getSystemClassLoader)`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`myClassLoader = new AbstractFileClassLoader(ctx.settings.outputDir.value, parent)`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+scala> val d: java.sql.Date = new java.sql.Date(100L)`
	`2`	`+val d: java.sql.Date = 1970-01-01`
	`3`	`+`