Merge pull request scala-js#4680 from sjrd/more-javalib-cleanups

More javalib cleanups

Author: gzm0

javalib/src/main/scala/java/math/BigDecimal.scala

@@ -811,7 +811,7 @@ class BigDecimal() extends Number with Comparable[BigDecimal] {
       val (q, l) = loop(1, q1.shiftRight(k), 0)
 
       // If  abs(q) != 1  then the quotient is periodic
-      if (q.abs() != BigInteger.ONE) {
+      if (!q.abs().equals(BigInteger.ONE)) {
         throw new ArithmeticException(
             "Non-terminating decimal expansion; no exact representable decimal result")
       }
@@ -1264,7 +1264,7 @@ class BigDecimal() extends Number with Comparable[BigDecimal] {
     case that: BigDecimal =>
       that._scale == this._scale && (
           if (_bitLength < 64) that._smallValue == this._smallValue
-          else this._intVal == that._intVal)
+          else this._intVal.equals(that._intVal))
     case _ => false
   }
 

javalib/src/main/scala/java/math/Logical.scala

@@ -44,7 +44,7 @@ private[math] object Logical {
     // scalastyle:off return
     if (bi.sign == 0) {
       BigInteger.MINUS_ONE
-    } else if (bi == BigInteger.MINUS_ONE) {
+    } else if (bi.equals(BigInteger.MINUS_ONE)) {
       BigInteger.ZERO
     } else {
       val resDigits = new Array[Int](bi.numberLength + 1)
@@ -88,9 +88,9 @@ private[math] object Logical {
   def and(bi: BigInteger, that: BigInteger): BigInteger = {
     if (that.sign == 0 || bi.sign == 0)
       BigInteger.ZERO
-    else if (that == BigInteger.MINUS_ONE)
+    else if (that.equals(BigInteger.MINUS_ONE))
       bi
-    else if (bi == BigInteger.MINUS_ONE)
+    else if (bi.equals(BigInteger.MINUS_ONE))
       that
     else if (bi.sign > 0 && that.sign > 0)
       andPositive(bi, that)
@@ -235,9 +235,9 @@ private[math] object Logical {
       bi
     else if (bi.sign == 0)
       BigInteger.ZERO
-    else if (bi == BigInteger.MINUS_ONE)
+    else if (bi.equals(BigInteger.MINUS_ONE))
       that.not()
-    else if (that == BigInteger.MINUS_ONE)
+    else if (that.equals(BigInteger.MINUS_ONE))
       BigInteger.ZERO
     else if (bi.sign > 0 && that.sign > 0)
       andNotPositive(bi, that)
@@ -446,7 +446,7 @@ private[math] object Logical {
 
   /** @see BigInteger#or(BigInteger) */
   def or(bi: BigInteger, that: BigInteger): BigInteger = {
-    if (that == BigInteger.MINUS_ONE || bi == BigInteger.MINUS_ONE) {
+    if (that.equals(BigInteger.MINUS_ONE) || bi.equals(BigInteger.MINUS_ONE)) {
       BigInteger.MINUS_ONE
     } else if (that.sign == 0) {
       bi
@@ -593,9 +593,9 @@ private[math] object Logical {
       bi
     } else if (bi.sign == 0) {
       that
-    } else if (that == BigInteger.MINUS_ONE) {
+    } else if (that.equals(BigInteger.MINUS_ONE)) {
       bi.not()
-    } else if (bi == BigInteger.MINUS_ONE) {
+    } else if (bi.equals(BigInteger.MINUS_ONE)) {
       that.not()
     } else if (bi.sign > 0) {
       if (that.sign > 0) {

javalib/src/main/scala/java/math/Primality.scala

@@ -134,13 +134,15 @@ private[math] object Primality {
       Arrays.binarySearch(Primes, n.digits(0)) >= 0
     } else {
       // To check if 'n' is divisible by some prime of the table
-      for (i <- 1 until Primes.length) {
+      var i: Int = 1
+      val primesLength = Primes.length
+      while (i != primesLength) {
         if (Division.remainderArrayByInt(n.digits, n.numberLength, Primes(i)) == 0)
           return false
+        i += 1
       }
 
       // To set the number of iterations necessary for Miller-Rabin test
-      var i: Int = 0
       val bitLength = n.bitLength()
       i = 2
       while (bitLength < Bits(i)) {
@@ -218,13 +220,15 @@ private[math] object Primality {
         }
       }
       // To execute Miller-Rabin for non-divisible numbers by all first primes
-      for (j <- 0 until gapSize) {
+      var j = 0
+      while (j != gapSize) {
         if (!isDivisible(j)) {
           Elementary.inplaceAdd(probPrime, j)
           if (millerRabin(probPrime, certainty)) {
             return probPrime
           }
         }
+        j += 1
       }
       Elementary.inplaceAdd(startPoint, gapSize)
     }
@@ -251,7 +255,9 @@ private[math] object Primality {
     val k = nMinus1.getLowestSetBit()
     val q = nMinus1.shiftRight(k)
     val rnd = new Random()
-    for (i <- 0 until t) {
+
+    var i = 0
+    while (i != t) {
       // To generate a witness 'x', first it use the primes of table
       if (i < Primes.length) {
         x = BiPrimes(i)
@@ -267,17 +273,21 @@ private[math] object Primality {
       }
 
       y = x.modPow(q, n)
-      if (!(y.isOne || y == nMinus1)) {
-        for (j <- 1 until k) {
-          if (y != nMinus1) {
+      if (!(y.isOne || y.equals(nMinus1))) {
+        var j = 1
+        while (j != k) {
+          if (!y.equals(nMinus1)) {
             y = y.multiply(y).mod(n)
             if (y.isOne)
               return false
           }
+          j += 1
         }
-        if (y != nMinus1)
+        if (!y.equals(nMinus1))
           return false
       }
+
+      i += 1
     }
     true
     // scalastyle:on return

javalib/src/main/scala/java/net/URI.scala

@@ -190,20 +190,24 @@ final class URI(origStr: String) extends Serializable with Comparable[URI] {
     import scala.util.hashing.MurmurHash3._
     import URI.normalizeEscapes
 
+    def normalizeEscapesHash(str: String): Int =
+      if (str == null) 0
+      else normalizeEscapes(str).hashCode()
+
     var acc = URI.uriSeed
-    acc = mix(acc, if (_scheme == null) 0 else _scheme.toLowerCase.##) // scheme may not contain escapes
+    acc = mix(acc, if (_scheme == null) 0 else _scheme.toLowerCase.hashCode()) // scheme may not contain escapes
     if (this.isOpaque()) {
-      acc = mix(acc, normalizeEscapes(this._schemeSpecificPart).##)
+      acc = mix(acc, normalizeEscapesHash(this._schemeSpecificPart))
     } else if (this._host != null) {
-      acc = mix(acc, normalizeEscapes(this._userInfo).##)
-      acc = mix(acc, this._host.toLowerCase.##)
-      acc = mix(acc, this._port.##)
+      acc = mix(acc, normalizeEscapesHash(this._userInfo))
+      acc = mix(acc, this._host.toLowerCase.hashCode())
+      acc = mix(acc, this._port.hashCode())
     } else {
-      acc = mix(acc, normalizeEscapes(this._authority).##)
+      acc = mix(acc, normalizeEscapesHash(this._authority))
     }
-    acc = mix(acc, normalizeEscapes(this._path).##)
-    acc = mix(acc, normalizeEscapes(this._query).##)
-    acc = mixLast(acc, normalizeEscapes(this._fragment).##)
+    acc = mix(acc, normalizeEscapesHash(this._path))
+    acc = mix(acc, normalizeEscapesHash(this._query))
+    acc = mixLast(acc, normalizeEscapesHash(this._fragment))
     finalizeHash(acc, 3)
   }
 

javalib/src/main/scala/java/nio/Buffer.scala

@@ -12,6 +12,8 @@
 
 package java.nio
 
+import java.util.internal.GenericArrayOps._
+
 import scala.scalajs.js.typedarray._
 
 abstract class Buffer private[nio] (val _capacity: Int) {
@@ -192,8 +194,9 @@ abstract class Buffer private[nio] (val _capacity: Int) {
   }
 
   @inline private[nio] def validateArrayIndexRange(
-      array: Array[_], offset: Int, length: Int): Unit = {
-    if (offset < 0 || length < 0 || offset > array.length - length)
+      array: Array[ElementType], offset: Int, length: Int)(
+      implicit arrayOps: ArrayOps[ElementType]): Unit = {
+    if (offset < 0 || length < 0 || offset > arrayOps.length(array) - length)
       throw new IndexOutOfBoundsException
   }
 

javalib/src/main/scala/java/nio/GenBuffer.scala

@@ -12,6 +12,8 @@
 
 package java.nio
 
+import java.util.internal.GenericArrayOps._
+
 private[nio] object GenBuffer {
   def apply[B <: Buffer](self: B): GenBuffer[B] =
     new GenBuffer(self)
@@ -49,8 +51,8 @@ private[nio] final class GenBuffer[B <: Buffer] private (val self: B)
   }
 
   @inline
-  def generic_get(dst: Array[ElementType],
-      offset: Int, length: Int): BufferType = {
+  def generic_get(dst: Array[ElementType], offset: Int, length: Int)(
+      implicit arrayOps: ArrayOps[ElementType]): BufferType = {
     validateArrayIndexRange(dst, offset, length)
     load(getPosAndAdvanceRead(length), dst, offset, length)
     self
@@ -82,8 +84,8 @@ private[nio] final class GenBuffer[B <: Buffer] private (val self: B)
   }
 
   @inline
-  def generic_put(src: Array[ElementType],
-      offset: Int, length: Int): BufferType = {
+  def generic_put(src: Array[ElementType], offset: Int, length: Int)(
+      implicit arrayOps: ArrayOps[ElementType]): BufferType = {
     ensureNotReadOnly()
     validateArrayIndexRange(src, offset, length)
     store(getPosAndAdvanceWrite(length), src, offset, length)
@@ -122,7 +124,7 @@ private[nio] final class GenBuffer[B <: Buffer] private (val self: B)
     var h = hashSeed
     var i = start
     while (i != end) {
-      h = mix(h, load(i).##)
+      h = mix(h, load(i).hashCode())
       i += 1
     }
     finalizeHash(h, end-start)
@@ -156,25 +158,27 @@ private[nio] final class GenBuffer[B <: Buffer] private (val self: B)
 
   @inline
   def generic_load(startIndex: Int,
-      dst: Array[ElementType], offset: Int, length: Int): Unit = {
+      dst: Array[ElementType], offset: Int, length: Int)(
+      implicit arrayOps: ArrayOps[ElementType]): Unit = {
     var selfPos = startIndex
     val endPos = selfPos + length
     var arrayIndex = offset
     while (selfPos != endPos) {
-      dst(arrayIndex) = load(selfPos)
+      arrayOps.set(dst, arrayIndex, load(selfPos))
       selfPos += 1
       arrayIndex += 1
     }
   }
 
   @inline
   def generic_store(startIndex: Int,
-      src: Array[ElementType], offset: Int, length: Int): Unit = {
+      src: Array[ElementType], offset: Int, length: Int)(
+      implicit arrayOps: ArrayOps[ElementType]): Unit = {
     var selfPos = startIndex
     val endPos = selfPos + length
     var arrayIndex = offset
     while (selfPos != endPos) {
-      store(selfPos, src(arrayIndex))
+      store(selfPos, arrayOps.get(src, arrayIndex))
       selfPos += 1
       arrayIndex += 1
     }

javalib/src/main/scala/java/nio/GenDataViewBuffer.scala

@@ -37,23 +37,11 @@ private[nio] object GenDataViewBuffer {
     val viewCapacity =
       (byteBufferLimit - byteBufferPos) / newDataViewBuffer.bytesPerElem
     val byteLength = viewCapacity * newDataViewBuffer.bytesPerElem
-    val dataView = newDataView(
+    val dataView = new DataView(
         byteArray.buffer, byteArray.byteOffset + byteBufferPos, byteLength)
     newDataViewBuffer(dataView,
         0, viewCapacity, byteBuffer.isReadOnly(), byteBuffer.isBigEndian)
   }
-
-  /* Work around for https://github.com/joyent/node/issues/6051
-   * node 0.10 does not like creating a DataView whose byteOffset is equal to
-   * the buffer's length, even if byteLength == 0.
-   */
-  @inline
-  private def newDataView(buffer: ArrayBuffer, byteOffset: Int, byteLength: Int): DataView = {
-    if (byteLength == 0)
-      lit(buffer = buffer, byteOffset = byteOffset, byteLength = byteLength).asInstanceOf[DataView]
-    else
-      new DataView(buffer, byteOffset, byteLength)
-  }
 }
 
 /* The underlying `val self` is intentionally public because
@@ -65,8 +53,6 @@ private[nio] final class GenDataViewBuffer[B <: Buffer] private (val self: B)
 
   import self._
 
-  import GenDataViewBuffer.newDataView
-
   type NewThisDataViewBuffer = GenDataViewBuffer.NewDataViewBuffer[BufferType]
 
   @inline
@@ -76,7 +62,7 @@ private[nio] final class GenDataViewBuffer[B <: Buffer] private (val self: B)
     val dataView = _dataView
     val pos = position()
     val newCapacity = limit() - pos
-    val slicedDataView = newDataView(dataView.buffer,
+    val slicedDataView = new DataView(dataView.buffer,
         dataView.byteOffset + bytesPerElem*pos, bytesPerElem*newCapacity)
     newDataViewBuffer(slicedDataView,
         0, newCapacity, isReadOnly(), isBigEndian)

javalib/src/main/scala/java/nio/GenHeapBuffer.scala

@@ -12,6 +12,8 @@
 
 package java.nio
 
+import java.util.internal.GenericArrayOps._
+
 private[nio] object GenHeapBuffer {
   def apply[B <: Buffer](self: B): GenHeapBuffer[B] =
     new GenHeapBuffer(self)
@@ -25,8 +27,9 @@ private[nio] object GenHeapBuffer {
   def generic_wrap[BufferType <: Buffer, ElementType](
       array: Array[ElementType], arrayOffset: Int, capacity: Int,
       initialPosition: Int, initialLength: Int, isReadOnly: Boolean)(
-      implicit newHeapBuffer: NewHeapBuffer[BufferType, ElementType]): BufferType = {
-    if (arrayOffset < 0 || capacity < 0 || arrayOffset+capacity > array.length)
+      implicit arrayOps: ArrayOps[ElementType],
+      newHeapBuffer: NewHeapBuffer[BufferType, ElementType]): BufferType = {
+    if (arrayOffset < 0 || capacity < 0 || arrayOffset+capacity > arrayOps.length(array))
       throw new IndexOutOfBoundsException
     val initialLimit = initialPosition + initialLength
     if (initialPosition < 0 || initialLength < 0 || initialLimit > capacity)
@@ -86,12 +89,12 @@ private[nio] final class GenHeapBuffer[B <: Buffer] private (val self: B)
   }
 
   @inline
-  def generic_load(index: Int): ElementType =
-    _array(_arrayOffset + index)
+  def generic_load(index: Int)(implicit arrayOps: ArrayOps[ElementType]): ElementType =
+    arrayOps.get(_array, _arrayOffset + index)
 
   @inline
-  def generic_store(index: Int, elem: ElementType): Unit =
-    _array(_arrayOffset + index) = elem
+  def generic_store(index: Int, elem: ElementType)(implicit arrayOps: ArrayOps[ElementType]): Unit =
+    arrayOps.set(_array, _arrayOffset + index, elem)
 
   @inline
   def generic_load(startIndex: Int,

javalib/src/main/scala/java/nio/charset/Charset.scala

@@ -36,7 +36,7 @@ abstract class Charset protected (canonicalName: String,
 
   override final def toString(): String = name()
 
-  override final def hashCode(): Int = name().##
+  override final def hashCode(): Int = name().hashCode()
 
   override final def compareTo(that: Charset): Int =
     name().compareToIgnoreCase(that.name())

javalib/src/main/scala/java/nio/charset/UTF_16_Common.scala

@@ -119,7 +119,7 @@ private[charset] abstract class UTF_16_Common protected (
       UTF_16_Common.this, 2.0f,
       if (endianness == AutoEndian) 4.0f else 2.0f,
       // Character 0xfffd
-      if (endianness == LittleEndian) Array(-3, -1) else Array(-1, -3)) {
+      if (endianness == LittleEndian) Array(-3.toByte, -1.toByte) else Array(-1.toByte, -3.toByte)) {
 
     private var needToWriteBOM: Boolean = endianness == AutoEndian