Skip to content

Dependency conflict #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterjhart opened this issue Feb 11, 2016 · 1 comment
Closed

Dependency conflict #2

peterjhart opened this issue Feb 11, 2016 · 1 comment

Comments

@peterjhart
Copy link

Latest versions of one/some/all dependencies break the build.

When I changed the semantics in my local package.json from "^" to "=" and everything worked.

Thanks for the repo!

@jameshibbard
Copy link
Collaborator

Thanks for pointing that out :)

I tested it and indeed it is broken. The error I'm getting is:

Error: [$injector:modulerr] Failed to instantiate module ng due to:
TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply')

Apparently, this is because Phantom 1.x doesn't have Function.prototype.bind. Instead you can use Phantom 2.x or a polyfill.

More info: angular/angular.js#13794

Alternatively, you can lock the versions in package.json (as you have done) and it works as expected. You don't need the equals sign, though. You can just specify the version number directly:

"angular-mocks": "1.3.15"

I've updated the repo accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants