upgrade packages (#2595)

* upgrade packages

not supports-color as that requires esm

* Remove the ESM bundle in browser check from postbuild

This has failed for several years without anyone noticing. Even if the exit status is non-zero, the
build does not fail, for whatever reason. So this has no meaning as of now.

* Downgrade Browserify

* Fix linting issues after upgrade

Author: fatso83

lib/sinon/util/core/get-property-descriptor.js

@@ -1,8 +1,18 @@
 "use strict";
 
-/* eslint-disable jsdoc/valid-types */
+/**
+ * @typedef {object} PropertyDescriptor
+ * @see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty#description
+ * @property {boolean} configurable defaults to false
+ * @property {boolean} enumerable   defaults to false
+ * @property {boolean} writable     defaults to false
+ * @property {*} value defaults to undefined
+ * @property {Function} get defaults to undefined
+ * @property {Function} set defaults to undefined
+ */
+
 /*
- * The following type def is strictly an illegal JSDoc, but the expression forms a
+ * The following type def is strictly speaking illegal in JSDoc, but the expression forms a
  * legal Typescript union type and is understood by Visual Studio and the IntelliJ
  * family of editors. The "TS" flavor of JSDoc is becoming the de-facto standard these
  * days for that reason (and the fact that JSDoc is essentially unmaintained)
@@ -13,7 +23,6 @@
  * a slightly enriched property descriptor
  * @property {boolean} isOwn true if the descriptor is owned by this object, false if it comes from the prototype
  */
-/* eslint-enable jsdoc/valid-types */
 
 /**
  * Returns a slightly modified property descriptor that one can tell is from the object or the prototype

package-lock.json

@@ -51,7 +51,7 @@
     "unimported": "unimported .",
     "pretest-webworker": "npm run build",
     "prebuild": "rimraf pkg && npm run check-dependencies",
-    "postbuild": "npm run test-esm-support && npm run check-esm-bundle-runs-in-browser",
+    "postbuild": "npm run test-esm-support ",
     "prebuild-docs": "./scripts/update-compatibility.js",
     "prepublishOnly": "npm run build",
     "prettier:check": "prettier --check '**/*.{js,css,md}'",
@@ -74,34 +74,34 @@
     "*.mjs": "eslint --quiet --ext mjs --parser-options=sourceType:module"
   },
   "dependencies": {
-    "@sinonjs/commons": "^3.0.0",
+    "@sinonjs/commons": "^3.0.1",
     "@sinonjs/fake-timers": "^11.2.2",
     "@sinonjs/samsam": "^8.0.0",
-    "diff": "^5.1.0",
-    "nise": "^5.1.5",
-    "supports-color": "^7.2.0"
+    "diff": "^5.2.0",
+    "nise": "^5.1.9",
+    "supports-color": "^7"
   },
   "devDependencies": {
-    "@babel/core": "^7.23.2",
-    "@sinonjs/eslint-config": "^4.1.0",
+    "@babel/core": "^7.24.4",
+    "@sinonjs/eslint-config": "^5.0.3",
     "@sinonjs/eslint-plugin-no-prototype-methods": "^0.1.1",
-    "@sinonjs/referee": "^10.0.1",
-    "@studio/changes": "^2.2.0",
+    "@sinonjs/referee": "^11.0.1",
+    "@studio/changes": "^3.0.0",
     "babel-plugin-istanbul": "^6.1.1",
     "babelify": "^10.0.0",
     "browserify": "^16.5.2",
     "debug": "^4.3.4",
     "dependency-check": "^4.1.0",
-    "lint-staged": "^15.0.2",
-    "mocha": "^10.2.0",
+    "lint-staged": "^15.2.2",
+    "mocha": "^10.4.0",
     "mochify": "^9.2.0",
     "nyc": "^15.1.0",
-    "prettier": "^3.0.3",
-    "puppeteer": "^21.4.0",
+    "prettier": "^3.2.5",
+    "puppeteer": "^22.7.1",
     "rimraf": "^5.0.5",
-    "semver": "^7.5.4",
+    "semver": "^7.6.0",
     "shelljs": "^0.8.5",
-    "unimported": "^1.30.0"
+    "unimported": "^1.31.0"
   },
   "files": [
     "lib",

package.json

@@ -19,7 +19,7 @@ import sinon from "../../pkg/sinon-esm.js";
 const { assert, refute } = referee;
 
 /**
- * @param action
+ * @param action {string} the export on the `sinon` namespace to test
  */
 function createTestSuite(action) {
     var stub;

test/es2015/module-support-assessment-test.mjs

@@ -681,6 +681,7 @@ describe("issues", function () {
         };
 
         let sandbox;
+
         beforeEach(function () {
             sandbox = sinon.createStubInstance(Foo);
         });

test/issues/issues-test.js

@@ -216,6 +216,7 @@ describe("sinonSpy.call", function () {
     describe("call.calledWithMatch", spyCallCalledTests("calledWithMatch"));
     // eslint-disable-next-line mocha/no-setup-in-describe
     describe("call.notCalledWith", spyCallNotCalledTests("notCalledWith"));
+
     describe(
         "call.notCalledWithMatch",
         // eslint-disable-next-line mocha/no-setup-in-describe

test/proxy-call-test.js

@@ -43,6 +43,7 @@ describe("proxy", function () {
                 });
                 assert.equals(named.printf("%n"), "cool");
             });
+
             it("anon", function () {
                 const anon = sinonSpy(function () {
                     return;

test/proxy-test.js

@@ -1113,6 +1113,7 @@ describe("spy", function () {
 
     // eslint-disable-next-line mocha/no-setup-in-describe
     describe(".alwaysCalledWith", spyAlwaysCalledTests("alwaysCalledWith"));
+
     describe(
         ".alwaysCalledWithMatch",
         // eslint-disable-next-line mocha/no-setup-in-describe
@@ -1168,6 +1169,7 @@ describe("spy", function () {
 
     // eslint-disable-next-line mocha/no-setup-in-describe
     describe(".neverCalledWith", spyNeverCalledTests("neverCalledWith"));
+
     describe(
         ".neverCalledWithMatch",
         // eslint-disable-next-line mocha/no-setup-in-describe

test/spy-test.js

@@ -1066,6 +1066,7 @@ describe("stub", function () {
 
         describe("lazy instantiation of exceptions", function () {
             let errorSpy;
+
             beforeEach(function () {
                 this.originalError = globalContext.Error;
                 errorSpy = createSpy(globalContext, "Error");