Skip to content

Commit eba42cc

Browse files
authored
Enable esm named exports (#2382)
* Enable esm named exports * Lint cjs files
1 parent b0cf544 commit eba42cc

File tree

4 files changed

+21
-4
lines changed

4 files changed

+21
-4
lines changed

build.js renamed to build.cjs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,11 @@ try {
1818
// We seem to have it already
1919
}
2020

21+
/**
22+
* @param entryPoint
23+
* @param config
24+
* @param done
25+
*/
2126
function makeBundle(entryPoint, config, done) {
2227
browserify(entryPoint, config).bundle(function (err, buffer) {
2328
if (err) {
@@ -39,7 +44,8 @@ makeBundle(
3944
},
4045
function (bundle) {
4146
var script = preamble + bundle;
42-
fs.writeFileSync("pkg/sinon.js", script);
47+
fs.writeFileSync("pkg/sinon.cjs", script);
48+
fs.writeFileSync("pkg/sinon.js", script); // WebWorker can only load js files
4349
}
4450
);
4551

@@ -53,7 +59,7 @@ makeBundle(
5359
},
5460
function (bundle) {
5561
var script = preamble + bundle;
56-
fs.writeFileSync("pkg/sinon-no-sourcemaps.js", script);
62+
fs.writeFileSync("pkg/sinon-no-sourcemaps.cjs", script);
5763
}
5864
);
5965

lib/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"type": "commonjs"
3+
}

package.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@
4343
"test-runnable-examples": "docs/release-source/release/examples/run-test.sh",
4444
"test": "npm run test-node && npm run test-headless && npm run test-webworker && npm run test-esm",
4545
"check-dependencies": "dependency-check package.json --no-dev --ignore-module esm",
46-
"build": "node ./build.js",
46+
"build": "node ./build.cjs",
4747
"build-docs": "cd docs; bundle exec jekyll build",
4848
"serve-docs": "cd docs; bundle exec jekyll serve --incremental --verbose",
49-
"lint": "eslint '**/*.{js,mjs}'",
49+
"lint": "eslint '**/*.{js,cjs,mjs}'",
5050
"pretest-webworker": "npm run build",
5151
"prebuild": "rimraf pkg && npm run check-dependencies",
5252
"postbuild": "npm run test-esm-bundle",
@@ -117,6 +117,11 @@
117117
"browser": "./lib/sinon.js",
118118
"main": "./lib/sinon.js",
119119
"module": "./pkg/sinon-esm.js",
120+
"exports": {
121+
"require": "./pkg/sinon.cjs",
122+
"import": "./pkg/sinon-esm.js"
123+
},
124+
"type": "module",
120125
"cdn": "./pkg/sinon.js",
121126
"jsdelivr": "./pkg/sinon.js",
122127
"esm": {

test/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"type": "commonjs"
3+
}

0 commit comments

Comments
 (0)