Skip to content

Commit 92dc087

Browse files
committed
Remove needless intermediary
1 parent 25311e4 commit 92dc087

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

lib/sinon/stub.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,12 @@ function stub(object, property) {
9494
var func = typeof actualDescriptor.value === "function" ? actualDescriptor.value : null;
9595
var s = createStub(func);
9696

97-
var propIsOwn = Boolean(actualDescriptor.isOwn);
98-
9997
extend.nonEnum(s, {
10098
rootObj: object,
10199
propName: property,
102-
shadowsPropOnPrototype: !propIsOwn,
100+
shadowsPropOnPrototype: !actualDescriptor.isOwn,
103101
restore: function restore() {
104-
if (actualDescriptor !== undefined && propIsOwn) {
102+
if (actualDescriptor !== undefined && actualDescriptor.isOwn) {
105103
Object.defineProperty(object, property, actualDescriptor);
106104
return;
107105
}

lib/sinon/util/core/get-property-descriptor.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
module.exports = function getPropertyDescriptor(object, property) {
44
var proto = object;
55
var descriptor;
6-
var isOwn = object && Object.getOwnPropertyDescriptor(object, property);
6+
var isOwn = Boolean(object && Object.getOwnPropertyDescriptor(object, property));
77

88
while (proto && !(descriptor = Object.getOwnPropertyDescriptor(proto, property))) {
99
proto = Object.getPrototypeOf(proto);

0 commit comments

Comments
 (0)