Skip to content

Commit beb7db1

Browse files
committed
Fix a crash in the new dependency check
Fixes #697 Fixes #696
1 parent c113539 commit beb7db1

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

Diff for: source/util.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ export const getNewDependencies = async (newPkg, rootDir) => {
8989

9090
const newDependencies = [];
9191

92-
for (const dependency of Object.keys(newPkg.dependencies)) {
93-
if (!oldPkg.dependencies[dependency]) {
92+
for (const dependency of Object.keys(newPkg.dependencies ?? {})) {
93+
if (!oldPkg.dependencies?.[dependency]) {
9494
newDependencies.push(dependency);
9595
}
9696
}

Diff for: source/version.js

+11-3
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,17 @@ export default class Version {
5858
}
5959

6060
static verifyRequirementSatisfied(dependency, version) {
61-
const depRange = pkg.engines[dependency];
62-
if (!new Version(version).satisfies(depRange)) {
63-
throw new Error(`Please upgrade to ${dependency}${depRange}`);
61+
if (!pkg.engines?.node) {
62+
throw new Error('Please include a `engines.node` field in your package.json');
63+
}
64+
65+
const versionRange = pkg.engines?.[dependency];
66+
if (!versionRange) {
67+
return;
68+
}
69+
70+
if (!new Version(version).satisfies(versionRange)) {
71+
throw new Error(`Please upgrade to ${dependency}${versionRange}`);
6472
}
6573
}
6674

0 commit comments

Comments
 (0)