Skip to content

Commit 4d2faac

Browse files
committed
Remove prefer-event-target from the recommended preset
It requires Node.js 16 and we target Node.js 14. Fixes #1854
1 parent 2ba0335 commit 4d2faac

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

configs/recommended.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ module.exports = {
7878
'unicorn/prefer-dom-node-dataset': 'error',
7979
'unicorn/prefer-dom-node-remove': 'error',
8080
'unicorn/prefer-dom-node-text-content': 'error',
81-
'unicorn/prefer-event-target': 'error',
81+
// TODO: Enable this by default when targeting Node.js 16.
82+
'unicorn/prefer-event-target': 'off',
8283
'unicorn/prefer-export-from': 'error',
8384
'unicorn/prefer-includes': 'error',
8485
'unicorn/prefer-json-parse-buffer': 'off',

docs/rules/prefer-event-target.md

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
<!-- Do not manually modify RULE_NOTICE part. Run: `npm run generate-rule-notices` -->
44
<!-- RULE_NOTICE -->
5-
*This rule is part of the [recommended](https://github.com/sindresorhus/eslint-plugin-unicorn#recommended-config) config.*
65
<!-- /RULE_NOTICE -->
76

87
While [`EventEmitter`](https://nodejs.org/api/events.html#class-eventemitter) is only available in Node.js, [`EventTarget`](https://developer.mozilla.org/en-US/docs/Web/API/EventTarget) is also available in *Deno* and browsers.

readme.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ Each rule has emojis denoting:
118118
| [prefer-dom-node-dataset](docs/rules/prefer-dom-node-dataset.md) | Prefer using `.dataset` on DOM elements over calling attribute methods. || 🔧 | |
119119
| [prefer-dom-node-remove](docs/rules/prefer-dom-node-remove.md) | Prefer `childNode.remove()` over `parentNode.removeChild(childNode)`. || 🔧 | 💡 |
120120
| [prefer-dom-node-text-content](docs/rules/prefer-dom-node-text-content.md) | Prefer `.textContent` over `.innerText`. || | 💡 |
121-
| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. | | | |
121+
| [prefer-event-target](docs/rules/prefer-event-target.md) | Prefer `EventTarget` over `EventEmitter`. | | | |
122122
| [prefer-export-from](docs/rules/prefer-export-from.md) | Prefer `export…from` when re-exporting. || 🔧 | 💡 |
123123
| [prefer-includes](docs/rules/prefer-includes.md) | Prefer `.includes()` over `.indexOf()` and `Array#some()` when checking for existence or non-existence. || 🔧 | 💡 |
124124
| [prefer-json-parse-buffer](docs/rules/prefer-json-parse-buffer.md) | Prefer reading a JSON file as a buffer. | | 🔧 | |

0 commit comments

Comments
 (0)