Skip to content

Commit 4b61c92

Browse files
authored
Allow rule.create to return undefined (#1912)
1 parent 7c8abf5 commit 4b61c92

File tree

5 files changed

+16
-8
lines changed

5 files changed

+16
-8
lines changed

rules/filename-case.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ const create = context => {
147147
const filenameWithExtension = context.getPhysicalFilename();
148148

149149
if (filenameWithExtension === '<input>' || filenameWithExtension === '<text>') {
150-
return {};
150+
return;
151151
}
152152

153153
return {

rules/no-empty-file.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const create = context => {
2020
const filename = context.getPhysicalFilename().toLowerCase();
2121

2222
if (!/\.(?:js|mjs|cjs|ts|mts|cts)$/.test(filename)) {
23-
return {};
23+
return;
2424
}
2525

2626
return {

rules/prefer-module.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ function create(context) {
218218
const filename = context.getFilename().toLowerCase();
219219

220220
if (filename.endsWith('.cjs')) {
221-
return {};
221+
return;
222222
}
223223

224224
const sourceCode = context.getSourceCode();

rules/string-content.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const create = context => {
7070
const replacements = getReplacements(patterns);
7171

7272
if (replacements.length === 0) {
73-
return {};
73+
return;
7474
}
7575

7676
return {

rules/utils/rule.js

+12-4
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,18 @@ function reportProblems(create) {
7171
return create;
7272
}
7373

74-
const wrapped = context => Object.fromEntries(
75-
Object.entries(create(context))
76-
.map(([selector, listener]) => [selector, reportListenerProblems(listener, context)]),
77-
);
74+
const wrapped = context => {
75+
const listeners = create(context);
76+
77+
if (!listeners) {
78+
return {};
79+
}
80+
81+
return Object.fromEntries(
82+
Object.entries(listeners)
83+
.map(([selector, listener]) => [selector, reportListenerProblems(listener, context)]),
84+
);
85+
};
7886

7987
wrappedFunctions.add(wrapped);
8088

0 commit comments

Comments
 (0)