Skip to content

Commit 1996125

Browse files
authored
prefer-string-replace-all: Minor tweak to the message (#1987)
1 parent 349c4fd commit 1996125

4 files changed

+9
-9
lines changed

rules/prefer-string-replace-all.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const MESSAGE_ID_USE_REPLACE_ALL = 'method';
99
const MESSAGE_ID_USE_STRING = 'pattern';
1010
const messages = {
1111
[MESSAGE_ID_USE_REPLACE_ALL]: 'Prefer `String#replaceAll()` over `String#replace()`.',
12-
[MESSAGE_ID_USE_STRING]: 'This pattern can be replaced with a string {{replacement}}.',
12+
[MESSAGE_ID_USE_STRING]: 'This pattern can be replaced with {{replacement}}.',
1313
};
1414

1515
const selector = methodCallSelector({
@@ -97,7 +97,7 @@ const create = context => ({
9797
messageId: MESSAGE_ID_USE_STRING,
9898
data: {
9999
// Show `This pattern can be replaced with a string literal.` for long strings
100-
replacement: patternReplacement.length < 20 ? patternReplacement : 'literal',
100+
replacement: patternReplacement.length < 20 ? patternReplacement : 'a string literal',
101101
},
102102
/** @param {import('eslint').Rule.RuleFixer} fixer */
103103
fix: fixer => fixer.replaceText(pattern, patternReplacement),

test/prefer-string-replace-all.mjs

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,6 @@ test.snapshot({
102102

103103
'foo.replaceAll(/a]/g, _)',
104104
'foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)',
105-
`foo.replaceAll(/a${' very'.repeat(30)} string/g, _)`,
105+
`foo.replaceAll(/a${' very'.repeat(30)} long string/g, _)`,
106106
],
107107
});

test/snapshots/prefer-string-replace-all.mjs.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,7 @@ Generated by [AVA](https://avajs.dev).
579579
580580
`␊
581581
> 1 | foo.replaceAll(/a]/g, _)␊
582-
| ^^^^^ This pattern can be replaced with a string 'a]'.␊
582+
| ^^^^^ This pattern can be replaced with 'a]'.␊
583583
`
584584

585585
## Invalid #36
@@ -595,21 +595,21 @@ Generated by [AVA](https://avajs.dev).
595595
596596
`␊
597597
> 1 | foo.replaceAll(/\\r\\n\\u{1f600}/gu, _)␊
598-
| ^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string '\\r\\n😀'.␊
598+
| ^^^^^^^^^^^^^^^^^ This pattern can be replaced with '\\r\\n😀'.␊
599599
`
600600

601601
## Invalid #37
602-
1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string/g, _)
602+
1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string/g, _)
603603

604604
> Output
605605
606606
`␊
607-
1 | foo.replaceAll('a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string', _)␊
607+
1 | foo.replaceAll('a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string', _)␊
608608
`
609609

610610
> Error 1/1
611611
612612
`␊
613-
> 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very string/g, _)␊
614-
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string literal.␊
613+
> 1 | foo.replaceAll(/a very very very very very very very very very very very very very very very very very very very very very very very very very very very very very very long string/g, _)␊
614+
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This pattern can be replaced with a string literal.␊
615615
`
Binary file not shown.

0 commit comments

Comments
 (0)