fix: invalid clone computed properties with vuex (vuejs#885) (vuejs#904)

sp1ker · iksim · commit 2150bda25b11 · 2019-04-18T14:04:12.000+09:00
diff --git a/src/backend/hook.js b/src/backend/hook.js
@@ -233,6 +233,11 @@ export function installHook (target) {
       for (var i in parent) {
         var attrs = Object.getOwnPropertyDescriptor(parent, i)
         if (attrs) {
+          if (attrs.hasOwnProperty('get') && attrs.get.name === 'computedGetter') {
+            Object.defineProperty(child, i, attrs)
+            continue
+          }
+
           child[i] = _clone(parent[i], depth - 1)
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,11 @@ export function installHook (target) {`
`233`	`233`	`for (var i in parent) {`
`234`	`234`	`var attrs = Object.getOwnPropertyDescriptor(parent, i)`
`235`	`235`	`if (attrs) {`
	`236`	`+ if (attrs.hasOwnProperty('get') && attrs.get.name === 'computedGetter') {`
	`237`	`+ Object.defineProperty(child, i, attrs)`
	`238`	`+ continue`
	`239`	`+ }`
	`240`	`+`
`236`	`241`	`child[i] = _clone(parent[i], depth - 1)`
`237`	`242`	`}`
`238`	`243`	`}`