validate fill_value in IntervalArray.take unconditionally (pandas-dev#36538)

jbrockmendel · web-flow · commit f04624104564 · 2020-09-22T07:54:31.000-07:00
diff --git a/pandas/core/arrays/interval.py b/pandas/core/arrays/interval.py
@@ -812,9 +812,7 @@ def take(self, indices, allow_fill=False, fill_value=None, axis=None, **kwargs):
 
         fill_left = fill_right = fill_value
         if allow_fill:
-            if (np.asarray(indices) == -1).any():
-                # We have excel tests that pass fill_value=True, xref GH#36466
-                fill_left, fill_right = self._validate_fill_value(fill_value)
+            fill_left, fill_right = self._validate_fill_value(fill_value)
 
         left_take = take(
             self.left, indices, allow_fill=allow_fill, fill_value=fill_left
diff --git a/pandas/io/formats/excel.py b/pandas/io/formats/excel.py
@@ -629,7 +629,9 @@ def _format_hierarchical_rows(self):
                 ):
 
                     values = levels.take(
-                        level_codes, allow_fill=levels._can_hold_na, fill_value=True
+                        level_codes,
+                        allow_fill=levels._can_hold_na,
+                        fill_value=levels._na_value,
                     )
 
                     for i in spans:

Original file line number	Diff line number	Diff line change
`@@ -629,7 +629,9 @@ def _format_hierarchical_rows(self):`
`629`	`629`	`):`
`630`	`630`
`631`	`631`	`values = levels.take(`
`632`		`- level_codes, allow_fill=levels._can_hold_na, fill_value=True`
	`632`	`+ level_codes,`
	`633`	`+ allow_fill=levels._can_hold_na,`
	`634`	`+ fill_value=levels._na_value,`
`633`	`635`	`)`
`634`	`636`
`635`	`637`	`for i in spans:`