check_untyped_defs pandas.core.generic

Author: simonjayhawkins

pandas/core/generic.py

@@ -8,6 +8,7 @@
 import re
 from textwrap import dedent
 from typing import (
+    TYPE_CHECKING,
     Any,
     Callable,
     Dict,
@@ -18,6 +19,7 @@
     Sequence,
     Set,
     Union,
+    cast,
 )
 import warnings
 import weakref
@@ -88,6 +90,9 @@
 from pandas.io.formats.printing import pprint_thing
 from pandas.tseries.frequencies import to_offset
 
+if TYPE_CHECKING:
+    from pandas import Series  # noqa: F401
+
 # goal is to be able to define the docs close to function, while still being
 # able to share
 _shared_docs = dict()  # type: Dict[str, str]
@@ -458,7 +463,7 @@ def _get_block_manager_axis(cls, axis):
             return m - axis
         return axis
 
-    def _get_axis_resolvers(self, axis):
+    def _get_axis_resolvers(self, axis: str) -> Dict[str, Union["Series", MultiIndex]]:
         # index or columns
         axis_index = getattr(self, axis)
         d = dict()
@@ -488,8 +493,8 @@ def _get_axis_resolvers(self, axis):
         d[axis] = dindex
         return d
 
-    def _get_index_resolvers(self):
-        d = {}
+    def _get_index_resolvers(self) -> Dict[str, Union["Series", MultiIndex]]:
+        d: Dict[str, Union["Series", MultiIndex]] = {}
         for axis_name in self._AXIS_ORDERS:
             d.update(self._get_axis_resolvers(axis_name))
         return d
@@ -2057,7 +2062,7 @@ def __setstate__(self, state):
             # old pickling format, for compatibility
             self._unpickle_matrix_compat(state)
 
-        self._item_cache = {}
+        self._item_cache: Dict = {}
 
     # ----------------------------------------------------------------------
     # Rendering Methods
@@ -3556,9 +3561,9 @@ class   animal   locomotion
             loc, new_ax = labels.get_loc_level(key, level=level, drop_level=drop_level)
 
             # create the tuple of the indexer
-            indexer = [slice(None)] * self.ndim
-            indexer[axis] = loc
-            indexer = tuple(indexer)
+            indexer_ = [slice(None)] * self.ndim
+            indexer_[axis] = loc
+            indexer = tuple(indexer_)
 
             result = self.iloc[indexer]
             setattr(result, result._get_axis_name(axis), new_ax)
@@ -5598,7 +5603,7 @@ def get_dtype_counts(self):
             stacklevel=2,
         )
 
-        from pandas import Series
+        from pandas import Series  # noqa: F811
 
         return Series(self._data.get_dtype_counts())
 
@@ -5641,7 +5646,7 @@ def get_ftype_counts(self):
             stacklevel=2,
         )
 
-        from pandas import Series
+        from pandas import Series  # noqa: F811
 
         return Series(self._data.get_ftype_counts())
 
@@ -5677,7 +5682,7 @@ def dtypes(self):
         string              object
         dtype: object
         """
-        from pandas import Series
+        from pandas import Series  # noqa: F811
 
         return Series(self._data.get_dtypes(), index=self._info_axis, dtype=np.object_)
 
@@ -5726,7 +5731,7 @@ def ftypes(self):
             stacklevel=2,
         )
 
-        from pandas import Series
+        from pandas import Series  # noqa: F811
 
         return Series(self._data.get_ftypes(), index=self._info_axis, dtype=np.object_)
 
@@ -5905,10 +5910,10 @@ def astype(self, dtype, copy=True, errors="raise"):
         elif is_extension_array_dtype(dtype) and self.ndim > 1:
             # GH 18099/22869: columnwise conversion to extension dtype
             # GH 24704: use iloc to handle duplicate column names
-            results = (
+            results = [
                 self.iloc[:, i].astype(dtype, copy=copy)
                 for i in range(len(self.columns))
-            )
+            ]
 
         else:
             # else, only a single dtype is given
@@ -6277,7 +6282,7 @@ def fillna(
 
             if self.ndim == 1:
                 if isinstance(value, (dict, ABCSeries)):
-                    from pandas import Series
+                    from pandas import Series  # noqa: F811
 
                     value = Series(value)
                 elif not is_list_like(value):
@@ -6681,8 +6686,11 @@ def replace(
                 to_replace = regex
                 regex = True
 
-            items = list(to_replace.items())
-            keys, values = zip(*items) if items else ([], [])
+            items = list(cast(dict, to_replace).items())
+            if items:
+                keys, values = zip(*items)
+            else:
+                keys, values = ([], [])
 
             are_mappings = [is_dict_like(v) for v in values]
 
@@ -7219,7 +7227,7 @@ def asof(self, where, subset=None):
 
             if where < start:
                 if not is_series:
-                    from pandas import Series
+                    from pandas import Series  # noqa: F811
 
                     return Series(index=self.columns, name=where)
                 return np.nan
@@ -10266,7 +10274,7 @@ def describe_1d(data):
 
         ldesc = [describe_1d(s) for _, s in data.items()]
         # set a convenient order for rows
-        names = []
+        names: List = []
         ldesc_indexes = sorted((x.index for x in ldesc), key=len)
         for idxnames in ldesc_indexes:
             for name in idxnames:

setup.cfg

@@ -182,9 +182,6 @@ check_untyped_defs=False
 [mypy-pandas.core.frame]
 check_untyped_defs=False
 
-[mypy-pandas.core.generic]
-check_untyped_defs=False
-
 [mypy-pandas.core.indexes.datetimes]
 check_untyped_defs=False