ensure we always close the result from the db

add some extra loggin to the errors

Author: shusson

docker/Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1.8
+FROM golang:1.9.2
 
 WORKDIR /go/src/app
 COPY . .

docker/docker-compose.yml

@@ -17,5 +17,5 @@ services:
     restart: always
     ports:
       - "8080:8080"
-    image: shusson/variantstore:1.3
+    image: shusson/variantstore:1.4
     entrypoint: 'go-wrapper run -d "${MYSQL_ROOT_USER}:${MYSQL_ROOT_PASSWORD}@tcp(db:${MYSQL_ROOT_PORT})/variants"'

variantstore.go

@@ -138,20 +138,20 @@ func VariantsIndex(db *sql.DB) http.HandlerFunc {
 		response := VariantResponse{true, []Variant{}, []int{}, ""}
 		vq, err := parse(r.URL.Query())
 		if err != nil {
-			errorResponse(&response, err.Error())
+			errorResponse(&response, "Parsing Error:" + err.Error())
 			json.NewEncoder(w).Encode(response)
 			return
 		}
 
 		count, err := countVariants(db, vq)
 		if err != nil {
-			errorResponse(&response, err.Error())
+			errorResponse(&response, "Count Error:" + err.Error())
 			json.NewEncoder(w).Encode(response)
 			return
 		}
 		vs, err := queryVariants(db, vq, count)
 		if err != nil {
-			errorResponse(&response, err.Error())
+			errorResponse(&response, "Query Error:" + err.Error())
 			json.NewEncoder(w).Encode(response)
 			return
 		}
@@ -216,6 +216,7 @@ func queryVariants(db *sql.DB, vq VariantQuery, count int) ([]Variant, error) {
 	if err != nil {
 		return nil, err
 	}
+	defer variants.Close()
 	var size = count - vq.Skip
 	if size < 0 {
 		size = 0