Merge pull request #1453 from Juneezee/refactor/errors.Is

shirou · web-flow · commit db89d1201090 · 2023-04-29T00:59:48.000+09:00
refactor(process): compare error with `errors.Is`
diff --git a/process/process_posix.go b/process/process_posix.go
@@ -122,7 +122,7 @@ func PidExistsWithContext(ctx context.Context, pid int32) (bool, error) {
 	if err == nil {
 		return true, nil
 	}
-	if err.Error() == "os: process already finished" {
+	if errors.Is(err, os.ErrProcessDone) {
 		return false, nil
 	}
 	var errno syscall.Errno

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ func PidExistsWithContext(ctx context.Context, pid int32) (bool, error) {`
`122`	`122`	`if err == nil {`
`123`	`123`	`return true, nil`
`124`	`124`	`}`
`125`		`- if err.Error() == "os: process already finished" {`
	`125`	`+ if errors.Is(err, os.ErrProcessDone) {`
`126`	`126`	`return false, nil`
`127`	`127`	`}`
`128`	`128`	`var errno syscall.Errno`